* [PATCH] clk: imx: fix build failure on i.MX SCU clk
@ 2020-12-03 23:07 Arnd Bergmann
2020-12-05 5:41 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-12-03 23:07 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer, Anson Huang
Cc: Arnd Bergmann, Anders Roxell, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Dong Aisheng, Peng Fan, linux-clk,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not,
the kernel fails to link with:
aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1
The only sensible configuration at the moment is to have both mean
the same thing, so make hide the first one to avoid broken
configurations.
Fixes: e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 3b393cb07295..47d9ec3abd2f 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -5,9 +5,7 @@ config MXC_CLK
depends on ARCH_MXC || COMPILE_TEST
config MXC_CLK_SCU
- tristate "IMX SCU clock"
- depends on ARCH_MXC || COMPILE_TEST
- depends on IMX_SCU && HAVE_ARM_SMCCC
+ tristate
config CLK_IMX1
def_bool SOC_IMX1
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: imx: fix build failure on i.MX SCU clk
2020-12-03 23:07 [PATCH] clk: imx: fix build failure on i.MX SCU clk Arnd Bergmann
@ 2020-12-05 5:41 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2020-12-05 5:41 UTC (permalink / raw)
To: Anson Huang, Arnd Bergmann, Michael Turquette, Sascha Hauer, Shawn Guo
Cc: Arnd Bergmann, Anders Roxell, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Dong Aisheng, Peng Fan, linux-clk,
linux-arm-kernel, linux-kernel
Quoting Arnd Bergmann (2020-12-03 15:07:52)
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not,
> the kernel fails to link with:
>
> aarch64-linux-ld: no input files
> make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
> aarch64-linux-ld: no input files
> make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1
>
> The only sensible configuration at the moment is to have both mean
> the same thing, so make hide the first one to avoid broken
> configurations.
>
> Fixes: e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Dong sent something similar at
https://lore.kernel.org/r/20201130084624.21113-1-aisheng.dong@nxp.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-05 5:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 23:07 [PATCH] clk: imx: fix build failure on i.MX SCU clk Arnd Bergmann
2020-12-05 5:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).