* Re: [PATCH][next] scsi: pm8001: remove space in a debug message
2020-11-24 9:38 [PATCH][next] scsi: pm8001: remove space in a debug message Colin King
@ 2020-11-24 23:23 ` Ewan D. Milne
2020-11-26 14:01 ` Jinpu Wang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ewan D. Milne @ 2020-11-24 23:23 UTC (permalink / raw)
To: Colin King, linux-scsi; +Cc: kernel-janitors, linux-kernel
On Tue, 2020-11-24 at 09:38 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two words that need separating with a space in a
> pm8001_dbg message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c
> b/drivers/scsi/pm8001/pm8001_hwi.c
> index 08d6cc9b50db..c8d4d87c5473 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -1031,7 +1031,7 @@ pm8001_chip_soft_rst(struct pm8001_hba_info
> *pm8001_ha)
> regVal = pm8001_cr32(pm8001_ha, 2,
> GSM_WRITE_DATA_PARITY_CHECK);
> pm8001_cw32(pm8001_ha, 2, GSM_WRITE_DATA_PARITY_CHECK,
> regVal3);
> pm8001_dbg(pm8001_ha, INIT,
> - "GSM 0x700048 - Write Data Parity Check Enableis set
> to = 0x%x\n",
> + "GSM 0x700048 - Write Data Parity Check Enable is
> set to = 0x%x\n",
> pm8001_cr32(pm8001_ha, 2,
> GSM_WRITE_DATA_PARITY_CHECK));
>
> /* step 13: bring the IOP and AAP1 out of reset */
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][next] scsi: pm8001: remove space in a debug message
2020-11-24 9:38 [PATCH][next] scsi: pm8001: remove space in a debug message Colin King
2020-11-24 23:23 ` Ewan D. Milne
@ 2020-11-26 14:01 ` Jinpu Wang
2020-12-01 4:35 ` Martin K. Petersen
2020-12-08 4:52 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Jinpu Wang @ 2020-11-26 14:01 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen,
Linux SCSI Mailinglist, kernel-janitors, linux-kernel
On Tue, Nov 24, 2020 at 10:38 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two words that need separating with a space in a
> pm8001_dbg message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Thanks
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index 08d6cc9b50db..c8d4d87c5473 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -1031,7 +1031,7 @@ pm8001_chip_soft_rst(struct pm8001_hba_info *pm8001_ha)
> regVal = pm8001_cr32(pm8001_ha, 2, GSM_WRITE_DATA_PARITY_CHECK);
> pm8001_cw32(pm8001_ha, 2, GSM_WRITE_DATA_PARITY_CHECK, regVal3);
> pm8001_dbg(pm8001_ha, INIT,
> - "GSM 0x700048 - Write Data Parity Check Enableis set to = 0x%x\n",
> + "GSM 0x700048 - Write Data Parity Check Enable is set to = 0x%x\n",
> pm8001_cr32(pm8001_ha, 2, GSM_WRITE_DATA_PARITY_CHECK));
>
> /* step 13: bring the IOP and AAP1 out of reset */
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] scsi: pm8001: remove space in a debug message
2020-11-24 9:38 [PATCH][next] scsi: pm8001: remove space in a debug message Colin King
2020-11-24 23:23 ` Ewan D. Milne
2020-11-26 14:01 ` Jinpu Wang
@ 2020-12-01 4:35 ` Martin K. Petersen
2020-12-08 4:52 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-12-01 4:35 UTC (permalink / raw)
To: Colin King
Cc: Jack Wang, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> There are two words that need separating with a space in a
> pm8001_dbg message. Fix it.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] scsi: pm8001: remove space in a debug message
2020-11-24 9:38 [PATCH][next] scsi: pm8001: remove space in a debug message Colin King
` (2 preceding siblings ...)
2020-12-01 4:35 ` Martin K. Petersen
@ 2020-12-08 4:52 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-12-08 4:52 UTC (permalink / raw)
To: Colin King, linux-scsi, James E . J . Bottomley, Jack Wang
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Tue, 24 Nov 2020 09:38:28 +0000, Colin King wrote:
> There are two words that need separating with a space in a
> pm8001_dbg message. Fix it.
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: pm8001: remove space in a debug message
https://git.kernel.org/mkp/scsi/c/c6131854e28a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread