From: Marc Zyngier <maz@kernel.org>
To: shawnguo@kernel.org, linux@rasmusvillemoes.dk,
leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com,
Biwen Li <biwen.li@oss.nxp.com>,
robh+dt@kernel.org, tglx@linutronix.de,
Lokesh Vutla <lokeshvutla@ti.com>
Cc: xiaobo.xie@nxp.com, Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Biwen Li <biwen.li@nxp.com>,
linux-kernel@vger.kernel.org, jiafei.pan@nxp.com,
Sekhar Nori <nsekhar@ti.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] irqchip/ti-sci-intr: Fix freeing of irqs
Date: Fri, 11 Dec 2020 15:01:38 +0000 [thread overview]
Message-ID: <160769813659.482133.15271657798818561633.b4-ty@kernel.org> (raw)
In-Reply-To: <20201102120631.11165-1-lokeshvutla@ti.com>
On Mon, 2 Nov 2020 17:36:31 +0530, Lokesh Vutla wrote:
> ti_sci_intr_irq_domain_free() assumes that out_irq of intr is stored in
> data->chip_data and uses it for calling ti_sci irq_free() and then
> mark the out_irq as available resource. But ti_sci_intr_irq_domain_alloc()
> is storing p_hwirq(parent's hardware irq) which is translated from out_irq.
> This is causing resource leakage and eventually out_irq resources might
> be exhausted. Fix ti_sci_intr_irq_domain_alloc() by storing the out_irq
> in data->chip_data.
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/ti-sci-intr: Fix freeing of irqs
commit: fc6c7cd3878641fd43189f15697e7ad0871f5c1a
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2020-12-11 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201102120631.11165-1-lokeshvutla@ti.com>
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] irqchip/ti-sci-intr: Fix freeing of irqs irqchip-bot for Lokesh Vutla
2020-12-11 15:01 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160769813659.482133.15271657798818561633.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=biwen.li@nxp.com \
--cc=biwen.li@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lokeshvutla@ti.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=xiaobo.xie@nxp.com \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).