* [PATCH] mlx4: style: replace zero-length array with flexible-array member.
@ 2020-12-30 6:28 YANG LI
2020-12-30 9:37 ` Tariq Toukan
2021-01-04 20:40 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: YANG LI @ 2020-12-30 6:28 UTC (permalink / raw)
To: kuba
Cc: davem, tariqt, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, netdev, linux-rdma, linux-kernel,
bpf, YANG LI
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use "flexible array members"[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9/process/
deprecated.html#zero-length-and-one-element-arrays
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci <abaci@linux.alibaba.com>
---
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
index e8ed2319..4029a8b 100644
--- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
+++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
@@ -314,7 +314,7 @@ struct mlx4_en_tx_ring {
struct mlx4_en_rx_desc {
/* actual number of entries depends on rx ring stride */
- struct mlx4_wqe_data_seg data[0];
+ struct mlx4_wqe_data_seg data[];
};
struct mlx4_en_rx_ring {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mlx4: style: replace zero-length array with flexible-array member.
2020-12-30 6:28 [PATCH] mlx4: style: replace zero-length array with flexible-array member YANG LI
@ 2020-12-30 9:37 ` Tariq Toukan
2021-01-04 20:40 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2020-12-30 9:37 UTC (permalink / raw)
To: YANG LI, kuba
Cc: davem, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, netdev, linux-rdma, linux-kernel,
bpf
On 12/30/2020 8:28 AM, YANG LI wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use "flexible array members"[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.9/process/
> deprecated.html#zero-length-and-one-element-arrays
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> index e8ed2319..4029a8b 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> @@ -314,7 +314,7 @@ struct mlx4_en_tx_ring {
>
> struct mlx4_en_rx_desc {
> /* actual number of entries depends on rx ring stride */
> - struct mlx4_wqe_data_seg data[0];
> + struct mlx4_wqe_data_seg data[];
> };
>
> struct mlx4_en_rx_ring {
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mlx4: style: replace zero-length array with flexible-array member.
2020-12-30 6:28 [PATCH] mlx4: style: replace zero-length array with flexible-array member YANG LI
2020-12-30 9:37 ` Tariq Toukan
@ 2021-01-04 20:40 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-04 20:40 UTC (permalink / raw)
To: YANG LI
Cc: davem, tariqt, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, netdev, linux-rdma, linux-kernel,
bpf
On Wed, 30 Dec 2020 14:28:51 +0800 YANG LI wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use "flexible array members"[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.9/process/
> deprecated.html#zero-length-and-one-element-arrays
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>
This breaks the build with allmodconfig, could you double check?
Are there dependencies?
In file included from drivers/net/ethernet/mellanox/mlx4/en_netdev.c:50:
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:316:27: error: flexible array member in a struct with no named members
316 | struct mlx4_wqe_data_seg data[];
| ^~~~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-04 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 6:28 [PATCH] mlx4: style: replace zero-length array with flexible-array member YANG LI
2020-12-30 9:37 ` Tariq Toukan
2021-01-04 20:40 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).