* [PATCH] ASoC: es8328: Remove redundant null check before clk_disable_unprepare
@ 2021-01-08 8:58 Xu Wang
2021-01-08 16:29 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2021-01-08 8:58 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, peter.ujfalusi,
kuninori.morimoto.gx, gustavoars, alsa-devel
Cc: linux-kernel
Because clk_disable_unprepare() already checked NULL clock parameter,
so the additional check is unnecessary, just remove it.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
sound/soc/codecs/es8328.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
index 7e26231a596a..b537300d0ce8 100644
--- a/sound/soc/codecs/es8328.c
+++ b/sound/soc/codecs/es8328.c
@@ -809,8 +809,7 @@ static void es8328_remove(struct snd_soc_component *component)
es8328 = snd_soc_component_get_drvdata(component);
- if (es8328->clk)
- clk_disable_unprepare(es8328->clk);
+ clk_disable_unprepare(es8328->clk);
regulator_bulk_disable(ARRAY_SIZE(es8328->supplies),
es8328->supplies);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: es8328: Remove redundant null check before clk_disable_unprepare
2021-01-08 8:58 [PATCH] ASoC: es8328: Remove redundant null check before clk_disable_unprepare Xu Wang
@ 2021-01-08 16:29 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-01-08 16:29 UTC (permalink / raw)
To: lgirdwood, alsa-devel, perex, tiwai, kuninori.morimoto.gx,
peter.ujfalusi, Xu Wang, gustavoars
Cc: linux-kernel
On Fri, 8 Jan 2021 08:58:34 +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: es8328: Remove redundant null check before clk_disable_unprepare
commit: 31c51a424f5163ee6f14fcc251f81078457123e1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-08 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 8:58 [PATCH] ASoC: es8328: Remove redundant null check before clk_disable_unprepare Xu Wang
2021-01-08 16:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).