* [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk
@ 2020-12-30 15:52 Arnd Bergmann
2021-01-11 1:41 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-30 15:52 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Dong Aisheng, Sebastian Andrzej Siewior
Cc: Arnd Bergmann, Anders Roxell, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Anson Huang, Peng Fan, linux-clk,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A previous patch introduced a harmless randconfig warning:
WARNING: unmet direct dependencies detected for MXC_CLK_SCU
Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
Selected by [m]:
- CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
Since the symbol is now hidden and only selected by other symbols,
just remove the dependencies and require the other drivers to
get it right.
Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 3061896503f3..47d9ec3abd2f 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -6,8 +6,6 @@ config MXC_CLK
config MXC_CLK_SCU
tristate
- depends on ARCH_MXC
- depends on IMX_SCU && HAVE_ARM_SMCCC
config CLK_IMX1
def_bool SOC_IMX1
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk
2020-12-30 15:52 [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk Arnd Bergmann
@ 2021-01-11 1:41 ` Shawn Guo
2021-01-12 19:26 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2021-01-11 1:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Michael Turquette, Stephen Boyd, Sascha Hauer, Dong Aisheng,
Sebastian Andrzej Siewior, Arnd Bergmann, Anders Roxell,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Anson Huang, Peng Fan, linux-clk, linux-arm-kernel, linux-kernel
On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A previous patch introduced a harmless randconfig warning:
>
> WARNING: unmet direct dependencies detected for MXC_CLK_SCU
> Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> Selected by [m]:
> - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
>
> Since the symbol is now hidden and only selected by other symbols,
> just remove the dependencies and require the other drivers to
> get it right.
>
> Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me.
Stephen, I assume that you will pick it up as a material for 5.11-rc.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk
2021-01-11 1:41 ` Shawn Guo
@ 2021-01-12 19:26 ` Stephen Boyd
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-01-12 19:26 UTC (permalink / raw)
To: Arnd Bergmann, Shawn Guo
Cc: Michael Turquette, Sascha Hauer, Dong Aisheng,
Sebastian Andrzej Siewior, Arnd Bergmann, Anders Roxell,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Anson Huang, Peng Fan, linux-clk, linux-arm-kernel, linux-kernel
Quoting Shawn Guo (2021-01-10 17:41:11)
> On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > A previous patch introduced a harmless randconfig warning:
> >
> > WARNING: unmet direct dependencies detected for MXC_CLK_SCU
> > Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> > Selected by [m]:
> > - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> >
> > Since the symbol is now hidden and only selected by other symbols,
> > just remove the dependencies and require the other drivers to
> > get it right.
> >
> > Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> > Reported-by: Anders Roxell <anders.roxell@linaro.org>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good to me.
>
> Stephen, I assume that you will pick it up as a material for 5.11-rc.
>
Sure. Applied to clk-fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 15:52 [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk Arnd Bergmann
2021-01-11 1:41 ` Shawn Guo
2021-01-12 19:26 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).