linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword
@ 2021-01-12  1:38 Zou Wei
  2021-01-13 14:14 ` Vinod Koul
  2021-01-14  2:10 ` Chunfeng Yun
  0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-01-12  1:38 UTC (permalink / raw)
  To: chunkuang.hu, p.zabel, chunfeng.yun, kishon, vkoul, matthias.bgg
  Cc: dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel, Zou Wei

Fix the following sparse warning:

drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
index 18c4812..eeb357b 100644
--- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
+++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
@@ -234,7 +234,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = {
 	{ },
 };
 
-struct platform_driver mtk_mipi_tx_driver = {
+static struct platform_driver mtk_mipi_tx_driver = {
 	.probe = mtk_mipi_tx_probe,
 	.remove = mtk_mipi_tx_remove,
 	.driver = {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword
  2021-01-12  1:38 [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword Zou Wei
@ 2021-01-13 14:14 ` Vinod Koul
  2021-01-14  2:10 ` Chunfeng Yun
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-01-13 14:14 UTC (permalink / raw)
  To: Zou Wei
  Cc: chunkuang.hu, p.zabel, chunfeng.yun, kishon, matthias.bgg,
	dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel

On 12-01-21, 09:38, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword
  2021-01-12  1:38 [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword Zou Wei
  2021-01-13 14:14 ` Vinod Koul
@ 2021-01-14  2:10 ` Chunfeng Yun
  1 sibling, 0 replies; 3+ messages in thread
From: Chunfeng Yun @ 2021-01-14  2:10 UTC (permalink / raw)
  To: Zou Wei
  Cc: chunkuang.hu, p.zabel, kishon, vkoul, matthias.bgg, dri-devel,
	linux-arm-kernel, linux-mediatek, linux-kernel

On Tue, 2021-01-12 at 09:38 +0800, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> index 18c4812..eeb357b 100644
> --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> @@ -234,7 +234,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = {
>  	{ },
>  };
>  
> -struct platform_driver mtk_mipi_tx_driver = {
> +static struct platform_driver mtk_mipi_tx_driver = {
>  	.probe = mtk_mipi_tx_probe,
>  	.remove = mtk_mipi_tx_remove,
>  	.driver = {

Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Thanks


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-14  2:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12  1:38 [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword Zou Wei
2021-01-13 14:14 ` Vinod Koul
2021-01-14  2:10 ` Chunfeng Yun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).