* [PATCH] rtlwifi: Assign boolean values to a bool variable
@ 2021-01-20 7:27 Jiapeng Zhong
2021-01-20 9:08 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Zhong @ 2021-01-20 7:27 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, kuba, bigeasy, colin.king, Larry.Finger,
andriy.shevchenko, linux-wireless, netdev, linux-kernel,
Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:
892:1-10: WARNING: Assignment of 0/1 to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
index be4c0e6..c198222 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
@@ -873,7 +873,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
dc_mode = true; /*TODO*/
under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
- low_power = 0; /*TODO*/
+ low_power = false; /*TODO*/
seq_printf(m, "\n %-35s = %s%s%s%s",
"Power Status",
(dc_mode ? "DC mode" : "AC mode"),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: Assign boolean values to a bool variable
2021-01-20 7:27 [PATCH] rtlwifi: Assign boolean values to a bool variable Jiapeng Zhong
@ 2021-01-20 9:08 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2021-01-20 9:08 UTC (permalink / raw)
To: Jiapeng Zhong
Cc: pkshih, kvalo, davem, kuba, colin.king, Larry.Finger,
andriy.shevchenko, linux-wireless, netdev, linux-kernel
On 2021-01-20 15:27:08 [+0800], Jiapeng Zhong wrote:
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index be4c0e6..c198222 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -873,7 +873,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
> dc_mode = true; /*TODO*/
> under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
> under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
> - low_power = 0; /*TODO*/
> + low_power = false; /*TODO*/
you could drop that assignment as it is already initialized to false at
the top.
> seq_printf(m, "\n %-35s = %s%s%s%s",
> "Power Status",
> (dc_mode ? "DC mode" : "AC mode"),
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-20 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 7:27 [PATCH] rtlwifi: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-20 9:08 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).