* [PATCH] mm/memcontrol: remove redundant NULL check
@ 2021-01-21 8:00 Yang Li
2021-02-02 10:12 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-01-21 8:00 UTC (permalink / raw)
To: hannes
Cc: mhocko, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel, Yang Li
Fix below warnings reported by coccicheck:
./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing
functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
mm/memcontrol.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 605f671..f6a561b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
for_each_node(nid) {
pn = mem_cgroup_nodeinfo(memcg, nid);
map = rcu_dereference_protected(pn->shrinker_map, true);
- if (map)
- kvfree(map);
+ kvfree(map);
rcu_assign_pointer(pn->shrinker_map, NULL);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/memcontrol: remove redundant NULL check
2021-01-21 8:00 [PATCH] mm/memcontrol: remove redundant NULL check Yang Li
@ 2021-02-02 10:12 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2021-02-02 10:12 UTC (permalink / raw)
To: Yang Li, hannes
Cc: mhocko, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel
On 21.01.21 09:00, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing
> functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> mm/memcontrol.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 605f671..f6a561b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
> for_each_node(nid) {
> pn = mem_cgroup_nodeinfo(memcg, nid);
> map = rcu_dereference_protected(pn->shrinker_map, true);
> - if (map)
> - kvfree(map);
> + kvfree(map);
> rcu_assign_pointer(pn->shrinker_map, NULL);
> }
> }
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-02 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 8:00 [PATCH] mm/memcontrol: remove redundant NULL check Yang Li
2021-02-02 10:12 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).