* [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable
@ 2021-01-20 7:31 Jiapeng Zhong
2021-01-23 3:03 ` Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Zhong @ 2021-01-20 7:31 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment
of 0/1 to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index f9142db..77a7acd 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -761,7 +761,7 @@ static struct purex_item *qla27xx_copy_fpin_pkt(struct scsi_qla_host *vha,
qla27xx_handle_8200_aen(scsi_qla_host_t *vha, uint16_t *mb)
{
struct qla_hw_data *ha = vha->hw;
- bool reset_isp_needed = 0;
+ bool reset_isp_needed = false;
ql_log(ql_log_warn, vha, 0x02f0,
"MPI Heartbeat stop. MPI reset is%s needed. "
@@ -777,7 +777,7 @@ static struct purex_item *qla27xx_copy_fpin_pkt(struct scsi_qla_host *vha,
if (ql2xfulldump_on_mpifail) {
ha->isp_ops->fw_dump(vha);
- reset_isp_needed = 1;
+ reset_isp_needed = true;
}
ha->isp_ops->mpi_fw_dump(vha, 1);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable
2021-01-20 7:31 [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable Jiapeng Zhong
@ 2021-01-23 3:03 ` Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-01-23 3:03 UTC (permalink / raw)
To: Jiapeng Zhong
Cc: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
Jiapeng,
> ./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment
> of 0/1 to bool variable.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable
2021-01-20 7:31 [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-23 3:03 ` Martin K. Petersen
@ 2021-01-27 4:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-01-27 4:54 UTC (permalink / raw)
To: njavali, Jiapeng Zhong
Cc: Martin K . Petersen, linux-kernel, GR-QLogic-Storage-Upstream,
linux-scsi, jejb
On Wed, 20 Jan 2021 15:31:59 +0800, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment
> of 0/1 to bool variable.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Assign boolean values to a bool variable
https://git.kernel.org/mkp/scsi/c/71311be1cd3e
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-27 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 7:31 [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-23 3:03 ` Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).