[PATCH] ASoC: codecs: add missing max_register in regmap config

[PATCH] ASoC: codecs: add missing max_register in regmap config

[Srinivas Kandagatla]

For some reason setting max_register was missed from regmap_config.
Without this cat /sys/kernel/debug/regmap/sdw:0:217:2010:0:1/range
actually throws below Warning.

WARNING: CPU: 7 PID: 540 at drivers/base/regmap/regmap-debugfs.c:160
 regmap_debugfs_get_dump_start.part.10+0x1e0/0x220
...
Call trace:
 regmap_debugfs_get_dump_start.part.10+0x1e0/0x220
 regmap_reg_ranges_read_file+0xc0/0x2e0
 full_proxy_read+0x64/0x98
 vfs_read+0xa8/0x1e0
 ksys_read+0x6c/0x100
 __arm64_sys_read+0x1c/0x28
 el0_svc_common.constprop.3+0x6c/0x190
 do_el0_svc+0x24/0x90
 el0_svc+0x14/0x20
 el0_sync_handler+0x90/0xb8
 el0_sync+0x158/0x180
...

Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/codecs/wsa881x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c
index 4530b74f5921..db87e07b11c9 100644
--- a/sound/soc/codecs/wsa881x.c
+++ b/sound/soc/codecs/wsa881x.c
@@ -640,6 +640,7 @@ static struct regmap_config wsa881x_regmap_config = {
 	.val_bits = 8,
 	.cache_type = REGCACHE_RBTREE,
 	.reg_defaults = wsa881x_defaults,
+	.max_register = WSA881X_SPKR_STATUS3,
 	.num_reg_defaults = ARRAY_SIZE(wsa881x_defaults),
 	.volatile_reg = wsa881x_volatile_register,
 	.readable_reg = wsa881x_readable_register,
-- 
2.21.0

Re: [PATCH] ASoC: codecs: add missing max_register in regmap config

[Mark Brown]

On Mon, 1 Feb 2021 16:14:29 +0000, Srinivas Kandagatla wrote:
> For some reason setting max_register was missed from regmap_config.
> Without this cat /sys/kernel/debug/regmap/sdw:0:217:2010:0:1/range
> actually throws below Warning.
> 
> WARNING: CPU: 7 PID: 540 at drivers/base/regmap/regmap-debugfs.c:160
>  regmap_debugfs_get_dump_start.part.10+0x1e0/0x220
> ...
> Call trace:
>  regmap_debugfs_get_dump_start.part.10+0x1e0/0x220
>  regmap_reg_ranges_read_file+0xc0/0x2e0
>  full_proxy_read+0x64/0x98
>  vfs_read+0xa8/0x1e0
>  ksys_read+0x6c/0x100
>  __arm64_sys_read+0x1c/0x28
>  el0_svc_common.constprop.3+0x6c/0x190
>  do_el0_svc+0x24/0x90
>  el0_svc+0x14/0x20
>  el0_sync_handler+0x90/0xb8
>  el0_sync+0x158/0x180
> ...

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: add missing max_register in regmap config
      commit: e8820dbddbcad7e91daacf7d42a49d1d04a4e489

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark