linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] firmware: ti_sci: rm: remove unneeded semicolon
@ 2021-02-02  6:23 Yang Li
  2021-02-02 17:17 ` Nishanth Menon
  0 siblings, 1 reply; 5+ messages in thread
From: Yang Li @ 2021-02-02  6:23 UTC (permalink / raw)
  To: nm; +Cc: t-kristo, ssantosh, linux-arm-kernel, linux-kernel, Yang Li

Eliminate the following coccicheck warning:
./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/firmware/ti_sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 235c7e7..5ae2040 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
 		desc->num = resp->range_num;
 		desc->start_sec = resp->range_start_sec;
 		desc->num_sec = resp->range_num_sec;
-	};
+	}
 
 fail:
 	ti_sci_put_one_xfer(&info->minfo, xfer);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon
  2021-02-02  6:23 [PATCH] firmware: ti_sci: rm: remove unneeded semicolon Yang Li
@ 2021-02-02 17:17 ` Nishanth Menon
  2021-02-02 18:04   ` [External] : " Santosh Shilimkar
  0 siblings, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2021-02-02 17:17 UTC (permalink / raw)
  To: Yang Li; +Cc: kristo, ssantosh, linux-arm-kernel, linux-kernel

On 14:23-20210202, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/firmware/ti_sci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 235c7e7..5ae2040 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
>  		desc->num = resp->range_num;
>  		desc->start_sec = resp->range_start_sec;
>  		desc->num_sec = resp->range_num_sec;
> -	};
> +	}
>  


Uggh.. thanks..

Reviewed-by: Nishanth Menon <nm@ti.com>


Santosh: I know you have send your Soc fixes for merge, but will be
great if you could pick for a future version, this is minor enough not
to bother the stable, I think..


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [External] : Re: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon
  2021-02-02 17:17 ` Nishanth Menon
@ 2021-02-02 18:04   ` Santosh Shilimkar
  0 siblings, 0 replies; 5+ messages in thread
From: Santosh Shilimkar @ 2021-02-02 18:04 UTC (permalink / raw)
  To: Nishanth Menon; +Cc: Yang Li, kristo, ssantosh, linux-arm-kernel, linux-kernel

On Feb 2, 2021, at 9:17 AM, Nishanth Menon <nm@ti.com> wrote:
> 
> On 14:23-20210202, Yang Li wrote:
>> Eliminate the following coccicheck warning:
>> ./drivers/firmware/ti_sci.c:1762:2-3: Unneeded semicolon
>> 
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/firmware/ti_sci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
>> index 235c7e7..5ae2040 100644
>> --- a/drivers/firmware/ti_sci.c
>> +++ b/drivers/firmware/ti_sci.c
>> @@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
>> 		desc->num = resp->range_num;
>> 		desc->start_sec = resp->range_start_sec;
>> 		desc->num_sec = resp->range_num_sec;
>> -	};
>> +	}
>> 
> 
> 
> Uggh.. thanks..
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>
> 
> 
> Santosh: I know you have send your Soc fixes for merge, but will be
> great if you could pick for a future version, this is minor enough not
> to bother the stable, I think..

Yes, this can wait for next one.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: ti_sci: rm: remove unneeded semicolon
  2021-11-14  5:53 Jason Wang
@ 2021-11-23  2:04 ` Nishanth Menon
  0 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2021-11-23  2:04 UTC (permalink / raw)
  To: Jason Wang, kristo
  Cc: Nishanth Menon, linux-arm-kernel, linux-kernel, ssantosh

Hi Jason Wang,

On Sun, 14 Nov 2021 13:53:33 +0800, Jason Wang wrote:
> The semicolon after `}' is unneeded. So, just remove it.
> 
> 

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[1/1] firmware: ti_sci: rm: remove unneeded semicolon
      commit: 7c1c1d36e83073aab18d3dd596b735bcc6ea7984

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] firmware: ti_sci: rm: remove unneeded semicolon
@ 2021-11-14  5:53 Jason Wang
  2021-11-23  2:04 ` Nishanth Menon
  0 siblings, 1 reply; 5+ messages in thread
From: Jason Wang @ 2021-11-14  5:53 UTC (permalink / raw)
  To: kristo; +Cc: nm, ssantosh, linux-arm-kernel, linux-kernel, Jason Wang

The semicolon after `}' is unneeded. So, just remove it.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/firmware/ti_sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 235c7e7869aa..5ae2040b8b02 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1759,7 +1759,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
 		desc->num = resp->range_num;
 		desc->start_sec = resp->range_start_sec;
 		desc->num_sec = resp->range_num_sec;
-	};
+	}
 
 fail:
 	ti_sci_put_one_xfer(&info->minfo, xfer);
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-23  2:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02  6:23 [PATCH] firmware: ti_sci: rm: remove unneeded semicolon Yang Li
2021-02-02 17:17 ` Nishanth Menon
2021-02-02 18:04   ` [External] : " Santosh Shilimkar
2021-11-14  5:53 Jason Wang
2021-11-23  2:04 ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).