* [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open
@ 2021-02-03 7:15 Xie He
2021-02-04 6:20 ` Martin Schiller
2021-02-05 2:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Xie He @ 2021-02-03 7:15 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, linux-x25, netdev, linux-kernel,
Martin Schiller, Krzysztof Halasa
Cc: Xie He
It's not meaningful to pass on LAPB error codes to HDLC code or other
parts of the system, because they will not understand the error codes.
Instead, use system-wide recognizable error codes.
Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
---
drivers/net/wan/hdlc_x25.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index bb164805804e..4aaa6388b9ee 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -169,11 +169,11 @@ static int x25_open(struct net_device *dev)
result = lapb_register(dev, &cb);
if (result != LAPB_OK)
- return result;
+ return -ENOMEM;
result = lapb_getparms(dev, ¶ms);
if (result != LAPB_OK)
- return result;
+ return -EINVAL;
if (state(hdlc)->settings.dce)
params.mode = params.mode | LAPB_DCE;
@@ -188,7 +188,7 @@ static int x25_open(struct net_device *dev)
result = lapb_setparms(dev, ¶ms);
if (result != LAPB_OK)
- return result;
+ return -EINVAL;
return 0;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open
2021-02-03 7:15 [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open Xie He
@ 2021-02-04 6:20 ` Martin Schiller
2021-02-05 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Martin Schiller @ 2021-02-04 6:20 UTC (permalink / raw)
To: Xie He
Cc: David S. Miller, Jakub Kicinski, linux-x25, netdev, linux-kernel,
Krzysztof Halasa
On 2021-02-03 08:15, Xie He wrote:
> It's not meaningful to pass on LAPB error codes to HDLC code or other
> parts of the system, because they will not understand the error codes.
>
> Instead, use system-wide recognizable error codes.
>
> Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
> ---
> drivers/net/wan/hdlc_x25.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
> index bb164805804e..4aaa6388b9ee 100644
> --- a/drivers/net/wan/hdlc_x25.c
> +++ b/drivers/net/wan/hdlc_x25.c
> @@ -169,11 +169,11 @@ static int x25_open(struct net_device *dev)
>
> result = lapb_register(dev, &cb);
> if (result != LAPB_OK)
> - return result;
> + return -ENOMEM;
>
> result = lapb_getparms(dev, ¶ms);
> if (result != LAPB_OK)
> - return result;
> + return -EINVAL;
>
> if (state(hdlc)->settings.dce)
> params.mode = params.mode | LAPB_DCE;
> @@ -188,7 +188,7 @@ static int x25_open(struct net_device *dev)
>
> result = lapb_setparms(dev, ¶ms);
> if (result != LAPB_OK)
> - return result;
> + return -EINVAL;
>
> return 0;
> }
Thanks for fixing this.
Acked-by: Martin Schiller <ms@dev.tdt.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open
2021-02-03 7:15 [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open Xie He
2021-02-04 6:20 ` Martin Schiller
@ 2021-02-05 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-05 2:20 UTC (permalink / raw)
To: Xie He; +Cc: davem, kuba, linux-x25, netdev, linux-kernel, ms, khc
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 2 Feb 2021 23:15:41 -0800 you wrote:
> It's not meaningful to pass on LAPB error codes to HDLC code or other
> parts of the system, because they will not understand the error codes.
>
> Instead, use system-wide recognizable error codes.
>
> Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: hdlc_x25: Return meaningful error code in x25_open
https://git.kernel.org/netdev/net/c/81b8be68ef8e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-05 2:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 7:15 [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open Xie He
2021-02-04 6:20 ` Martin Schiller
2021-02-05 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).