* [PATCH] mm/arm64: Correct obsolete comment in do_page_fault()
@ 2021-02-05 9:09 Miaohe Lin
2021-02-05 18:52 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2021-02-05 9:09 UTC (permalink / raw)
To: catalin.marinas, will
Cc: akpm, peterx, mark.rutland, elver, andreyknvl, vincenzo.frascino,
pcc, linux-arm-kernel, linux-kernel, linmiaohe
commit d8ed45c5dcd4 ("mmap locking API: use coccinelle to convert mmap_sem
rwsem call sites") has convertd down_read_trylock() to mmap_read_trylock().
But it forgot to update the relevant comment.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
arch/arm64/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 304eef9b7d44..eaa373dab731 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -576,7 +576,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
mmap_read_lock(mm);
} else {
/*
- * The above down_read_trylock() might have succeeded in which
+ * The above mmap_read_trylock() might have succeeded in which
* case, we'll have missed the might_sleep() from down_read().
*/
might_sleep();
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/arm64: Correct obsolete comment in do_page_fault()
2021-02-05 9:09 [PATCH] mm/arm64: Correct obsolete comment in do_page_fault() Miaohe Lin
@ 2021-02-05 18:52 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2021-02-05 18:52 UTC (permalink / raw)
To: Miaohe Lin, catalin.marinas
Cc: kernel-team, Will Deacon, vincenzo.frascino, mark.rutland,
andreyknvl, linux-kernel, akpm, pcc, linux-arm-kernel, peterx,
elver
On Fri, 5 Feb 2021 04:09:19 -0500, Miaohe Lin wrote:
> commit d8ed45c5dcd4 ("mmap locking API: use coccinelle to convert mmap_sem
> rwsem call sites") has convertd down_read_trylock() to mmap_read_trylock().
> But it forgot to update the relevant comment.
Applied to arm64 (for-next/cosmetic), thanks!
[1/1] mm/arm64: Correct obsolete comment in do_page_fault()
https://git.kernel.org/arm64/c/abd4737f67d7
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 9:09 [PATCH] mm/arm64: Correct obsolete comment in do_page_fault() Miaohe Lin
2021-02-05 18:52 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).