* [PATCH] clocksource: davinci: move pr_fmt() before the includes
@ 2021-01-11 14:08 Bartosz Golaszewski
2021-01-11 15:28 ` David Lechner
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2021-01-11 14:08 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, David Lechner, Sekhar Nori
Cc: linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
We no longer need to undef pr_fmt if we define our own before including
any headers.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/clocksource/timer-davinci.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
index bb4eee31ae08..9996c0542520 100644
--- a/drivers/clocksource/timer-davinci.c
+++ b/drivers/clocksource/timer-davinci.c
@@ -7,6 +7,8 @@
* (with tiny parts adopted from code by Kevin Hilman <khilman@baylibre.com>)
*/
+#define pr_fmt(fmt) "%s: " fmt, __func__
+
#include <linux/clk.h>
#include <linux/clockchips.h>
#include <linux/interrupt.h>
@@ -17,9 +19,6 @@
#include <clocksource/timer-davinci.h>
-#undef pr_fmt
-#define pr_fmt(fmt) "%s: " fmt, __func__
-
#define DAVINCI_TIMER_REG_TIM12 0x10
#define DAVINCI_TIMER_REG_TIM34 0x14
#define DAVINCI_TIMER_REG_PRD12 0x18
--
2.29.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes
2021-01-11 14:08 [PATCH] clocksource: davinci: move pr_fmt() before the includes Bartosz Golaszewski
@ 2021-01-11 15:28 ` David Lechner
2021-02-04 12:37 ` Bartosz Golaszewski
2021-02-10 10:06 ` [tip: timers/core] clocksource/drivers/davinci: Move " tip-bot2 for Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: David Lechner @ 2021-01-11 15:28 UTC (permalink / raw)
To: Bartosz Golaszewski, Daniel Lezcano, Thomas Gleixner, Sekhar Nori
Cc: linux-kernel, Bartosz Golaszewski
On 1/11/21 8:08 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We no longer need to undef pr_fmt if we define our own before including
> any headers.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
Acked-by: David Lechner <david@lechnology.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes
2021-01-11 14:08 [PATCH] clocksource: davinci: move pr_fmt() before the includes Bartosz Golaszewski
2021-01-11 15:28 ` David Lechner
@ 2021-02-04 12:37 ` Bartosz Golaszewski
2021-02-04 12:40 ` Daniel Lezcano
2021-02-10 10:06 ` [tip: timers/core] clocksource/drivers/davinci: Move " tip-bot2 for Bartosz Golaszewski
2 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2021-02-04 12:37 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, David Lechner, Sekhar Nori
Cc: Linux Kernel Mailing List, Bartosz Golaszewski
On Mon, Jan 11, 2021 at 3:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We no longer need to undef pr_fmt if we define our own before including
> any headers.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/clocksource/timer-davinci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
> index bb4eee31ae08..9996c0542520 100644
> --- a/drivers/clocksource/timer-davinci.c
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -7,6 +7,8 @@
> * (with tiny parts adopted from code by Kevin Hilman <khilman@baylibre.com>)
> */
>
> +#define pr_fmt(fmt) "%s: " fmt, __func__
> +
> #include <linux/clk.h>
> #include <linux/clockchips.h>
> #include <linux/interrupt.h>
> @@ -17,9 +19,6 @@
>
> #include <clocksource/timer-davinci.h>
>
> -#undef pr_fmt
> -#define pr_fmt(fmt) "%s: " fmt, __func__
> -
> #define DAVINCI_TIMER_REG_TIM12 0x10
> #define DAVINCI_TIMER_REG_TIM34 0x14
> #define DAVINCI_TIMER_REG_PRD12 0x18
> --
> 2.29.1
>
Gentle ping.
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: timers/core] clocksource/drivers/davinci: Move pr_fmt() before the includes
2021-01-11 14:08 [PATCH] clocksource: davinci: move pr_fmt() before the includes Bartosz Golaszewski
2021-01-11 15:28 ` David Lechner
2021-02-04 12:37 ` Bartosz Golaszewski
@ 2021-02-10 10:06 ` tip-bot2 for Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Bartosz Golaszewski @ 2021-02-10 10:06 UTC (permalink / raw)
To: linux-tip-commits
Cc: Bartosz Golaszewski, David Lechner, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 98509310e490bf3de13c96fbbbca8ef4af9db010
Gitweb: https://git.kernel.org/tip/98509310e490bf3de13c96fbbbca8ef4af9db010
Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
AuthorDate: Mon, 11 Jan 2021 15:08:14 +01:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jan 2021 16:31:39 +01:00
clocksource/drivers/davinci: Move pr_fmt() before the includes
We no longer need to undef pr_fmt if we define our own before including
any headers.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: David Lechner <david@lechnology.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210111140814.3668-1-brgl@bgdev.pl
---
drivers/clocksource/timer-davinci.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
index bb4eee3..9996c05 100644
--- a/drivers/clocksource/timer-davinci.c
+++ b/drivers/clocksource/timer-davinci.c
@@ -7,6 +7,8 @@
* (with tiny parts adopted from code by Kevin Hilman <khilman@baylibre.com>)
*/
+#define pr_fmt(fmt) "%s: " fmt, __func__
+
#include <linux/clk.h>
#include <linux/clockchips.h>
#include <linux/interrupt.h>
@@ -17,9 +19,6 @@
#include <clocksource/timer-davinci.h>
-#undef pr_fmt
-#define pr_fmt(fmt) "%s: " fmt, __func__
-
#define DAVINCI_TIMER_REG_TIM12 0x10
#define DAVINCI_TIMER_REG_TIM34 0x14
#define DAVINCI_TIMER_REG_PRD12 0x18
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-10 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 14:08 [PATCH] clocksource: davinci: move pr_fmt() before the includes Bartosz Golaszewski
2021-01-11 15:28 ` David Lechner
2021-02-04 12:37 ` Bartosz Golaszewski
2021-02-04 12:40 ` Daniel Lezcano
2021-02-10 10:06 ` [tip: timers/core] clocksource/drivers/davinci: Move " tip-bot2 for Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).