* [PATCH] scsi: qedf: Switch to using the new API kobj_to_dev()
@ 2021-02-22 7:34 Yang Li
0 siblings, 0 replies; only message in thread
From: Yang Li @ 2021-02-22 7:34 UTC (permalink / raw)
To: skashyap
Cc: jhasan, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel, Yang Li
fixed the following coccicheck:
./drivers/scsi/qedf/qedf_attr.c:105:26-27: WARNING opportunity for
kobj_to_dev()
./drivers/scsi/qedf/qedf_attr.c:134:24-25: WARNING opportunity for
kobj_to_dev()
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/scsi/qedf/qedf_attr.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_attr.c b/drivers/scsi/qedf/qedf_attr.c
index d995f72..33d2281 100644
--- a/drivers/scsi/qedf/qedf_attr.c
+++ b/drivers/scsi/qedf/qedf_attr.c
@@ -101,8 +101,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
size_t count)
{
ssize_t ret = 0;
- struct fc_lport *lport = shost_priv(dev_to_shost(container_of(kobj,
- struct device, kobj)));
+ struct fc_lport *lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
struct qedf_ctx *qedf = lport_priv(lport);
if (test_bit(QEDF_GRCDUMP_CAPTURE, &qedf->flags)) {
@@ -130,8 +129,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
return ret;
- lport = shost_priv(dev_to_shost(container_of(kobj,
- struct device, kobj)));
+ lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
qedf = lport_priv(lport);
buf[1] = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-22 7:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 7:34 [PATCH] scsi: qedf: Switch to using the new API kobj_to_dev() Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).