* [PATCH] mtd: rawnand: qcom: Rename parameter name in macro
@ 2021-02-22 7:35 Md Sadre Alam
2021-02-23 16:15 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Md Sadre Alam @ 2021-02-22 7:35 UTC (permalink / raw)
To: miquel.raynal, mani, boris.brezillon, linux-mtd, linux-kernel
Cc: Md Sadre Alam
This change will rename parameter name in macro
nandc_set_read_loc().renamed parameter names are
cw_offset, read_size, is_last_read_loc.
Sinc in QPIC V2 on-wards there is separate location
register to read last code word, so to just differnciate
b/w is_last_read_loc from last_cw this change needed.
Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org>
---
drivers/mtd/nand/raw/qcom_nandc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index 4189a7f..bfefb4e 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -181,11 +181,11 @@
#define ECC_BCH_4BIT BIT(2)
#define ECC_BCH_8BIT BIT(3)
-#define nandc_set_read_loc(nandc, reg, offset, size, is_last) \
+#define nandc_set_read_loc(nandc, reg, cw_offset, read_size, is_last_read_loc) \
nandc_set_reg(nandc, NAND_READ_LOCATION_##reg, \
- ((offset) << READ_LOCATION_OFFSET) | \
- ((size) << READ_LOCATION_SIZE) | \
- ((is_last) << READ_LOCATION_LAST))
+ ((cw_offset) << READ_LOCATION_OFFSET) | \
+ ((read_size) << READ_LOCATION_SIZE) | \
+ ((is_last_read_loc) << READ_LOCATION_LAST))
/*
* Returns the actual register address for all NAND_DEV_ registers
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: qcom: Rename parameter name in macro
2021-02-22 7:35 [PATCH] mtd: rawnand: qcom: Rename parameter name in macro Md Sadre Alam
@ 2021-02-23 16:15 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2021-02-23 16:15 UTC (permalink / raw)
To: Md Sadre Alam; +Cc: mani, boris.brezillon, linux-mtd, linux-kernel
Hello,
Md Sadre Alam <mdalam@codeaurora.org> wrote on Mon, 22 Feb 2021
13:05:42 +0530:
> This change will rename parameter name in macro
> nandc_set_read_loc().renamed parameter names are
> cw_offset, read_size, is_last_read_loc.
> Sinc in QPIC V2 on-wards there is separate location
> register to read last code word, so to just differnciate
> b/w is_last_read_loc from last_cw this change needed.
"
Rename the parameters of the nandc_set_read_loc() macro to avoid the
confusion between is_last_read_loc which <explain what it is> and
<last_cw> which <explain what it is as well>.
>
> Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org>
> ---
> drivers/mtd/nand/raw/qcom_nandc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 4189a7f..bfefb4e 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -181,11 +181,11 @@
> #define ECC_BCH_4BIT BIT(2)
> #define ECC_BCH_8BIT BIT(3)
>
> -#define nandc_set_read_loc(nandc, reg, offset, size, is_last) \
> +#define nandc_set_read_loc(nandc, reg, cw_offset, read_size, is_last_read_loc) \
> nandc_set_reg(nandc, NAND_READ_LOCATION_##reg, \
> - ((offset) << READ_LOCATION_OFFSET) | \
> - ((size) << READ_LOCATION_SIZE) | \
> - ((is_last) << READ_LOCATION_LAST))
> + ((cw_offset) << READ_LOCATION_OFFSET) | \
> + ((read_size) << READ_LOCATION_SIZE) | \
> + ((is_last_read_loc) << READ_LOCATION_LAST))
>
> /*
> * Returns the actual register address for all NAND_DEV_ registers
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-23 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 7:35 [PATCH] mtd: rawnand: qcom: Rename parameter name in macro Md Sadre Alam
2021-02-23 16:15 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).