* [PATCH] soc: ti: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
@ 2021-03-13 3:33 Wang Qing
2021-03-13 13:27 ` Nishanth Menon
0 siblings, 1 reply; 2+ messages in thread
From: Wang Qing @ 2021-03-13 3:33 UTC (permalink / raw)
To: Nishanth Menon, Santosh Shilimkar, linux-pm, linux-kernel,
linux-arm-kernel
Cc: Wang Qing
Fix the following coccicheck warning:
WARNING:pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/soc/ti/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
index 5376f3d..b3c7460
--- a/drivers/soc/ti/smartreflex.c
+++ b/drivers/soc/ti/smartreflex.c
@@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
+DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
omap_sr_autocomp_store, "%llu\n");
static int omap_sr_probe(struct platform_device *pdev)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: ti: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
2021-03-13 3:33 [PATCH] soc: ti: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Wang Qing
@ 2021-03-13 13:27 ` Nishanth Menon
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2021-03-13 13:27 UTC (permalink / raw)
To: Wang Qing; +Cc: Santosh Shilimkar, linux-pm, linux-kernel, linux-arm-kernel
On 11:33-20210313, Wang Qing wrote:
> Fix the following coccicheck warning:
> WARNING:pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE.
>
Reviewed-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-13 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 3:33 [PATCH] soc: ti: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Wang Qing
2021-03-13 13:27 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).