* [PATCH V2] ata: sata_highbank: delete redundant print and fix return value
@ 2021-03-15 2:24 Wang Qing
0 siblings, 0 replies; only message in thread
From: Wang Qing @ 2021-03-15 2:24 UTC (permalink / raw)
To: Jens Axboe, linux-ide, linux-kernel; +Cc: Wang Qing
platform_get_irq() has already checked and printed the return value,
the printing here is nothing special, and should corrected to < 0.
Also, thhe return value should return a real error.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/ata/sata_highbank.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 64b2ef1..a43d42a
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- dev_err(dev, "no irq\n");
+ if (irq < 0)
return irq;
- }
hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL);
if (!hpriv) {
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-15 2:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 2:24 [PATCH V2] ata: sata_highbank: delete redundant print and fix return value Wang Qing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).