* [PATCH] rtc: tps65910: include linux/property.h
@ 2021-02-25 13:42 Arnd Bergmann
2021-02-27 8:08 ` Dmitry Osipenko
2021-03-15 21:39 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-02-25 13:42 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Dmitry Osipenko
Cc: Arnd Bergmann, Bartosz Golaszewski, linux-rtc, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The added device_property_present() call causes a build
failure in some configurations because of the missing header:
drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]
Fixes: 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/rtc/rtc-tps65910.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index 288abb1abdb8..bc89c62ccb9b 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -18,6 +18,7 @@
#include <linux/rtc.h>
#include <linux/bcd.h>
#include <linux/math64.h>
+#include <linux/property.h>
#include <linux/platform_device.h>
#include <linux/interrupt.h>
#include <linux/mfd/tps65910.h>
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: tps65910: include linux/property.h
2021-02-25 13:42 [PATCH] rtc: tps65910: include linux/property.h Arnd Bergmann
@ 2021-02-27 8:08 ` Dmitry Osipenko
2021-03-15 21:39 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2021-02-27 8:08 UTC (permalink / raw)
To: Arnd Bergmann, Alessandro Zummo, Alexandre Belloni
Cc: Arnd Bergmann, Bartosz Golaszewski, linux-rtc, linux-kernel
25.02.2021 16:42, Arnd Bergmann пишет:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The added device_property_present() call causes a build
> failure in some configurations because of the missing header:
>
> drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]
>
> Fixes: 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/rtc/rtc-tps65910.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
> index 288abb1abdb8..bc89c62ccb9b 100644
> --- a/drivers/rtc/rtc-tps65910.c
> +++ b/drivers/rtc/rtc-tps65910.c
> @@ -18,6 +18,7 @@
> #include <linux/rtc.h>
> #include <linux/bcd.h>
> #include <linux/math64.h>
> +#include <linux/property.h>
> #include <linux/platform_device.h>
> #include <linux/interrupt.h>
> #include <linux/mfd/tps65910.h>
>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: tps65910: include linux/property.h
2021-02-25 13:42 [PATCH] rtc: tps65910: include linux/property.h Arnd Bergmann
2021-02-27 8:08 ` Dmitry Osipenko
@ 2021-03-15 21:39 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2021-03-15 21:39 UTC (permalink / raw)
To: Dmitry Osipenko, Alessandro Zummo, Arnd Bergmann
Cc: Alexandre Belloni, Bartosz Golaszewski, Arnd Bergmann, linux-rtc,
linux-kernel
On Thu, 25 Feb 2021 14:42:04 +0100, Arnd Bergmann wrote:
> The added device_property_present() call causes a build
> failure in some configurations because of the missing header:
>
> drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]
Applied, thanks!
[1/1] rtc: tps65910: include linux/property.h
commit: 936d3685e62436a378f02b8b74759b054d4aeca1
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-15 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 13:42 [PATCH] rtc: tps65910: include linux/property.h Arnd Bergmann
2021-02-27 8:08 ` Dmitry Osipenko
2021-03-15 21:39 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).