[PATCH v3 0/2] AM64: Add USB support

[PATCH v3 0/2] AM64: Add USB support

[Aswath Govindraju]

The following series of patches, add USB support for AM642 evm.

USB test logs,
https://pastebin.ubuntu.com/p/YSQRBWGmzd/

Changes since v2:
- dropped compatible string "ti,j721e-usb" leading to DT schema errors
- Reran test logs
- Couldn't pick up reviewed-by from kishon as a change was made in the
  patch

Changes since v1:
- Rebased the patches on top of ti-k3-dts-next
- Added test logs

Aswath Govindraju (2):
  arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
  arm64: dts: ti: k3-am642-evm: Add USB support

 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
 2 files changed, 48 insertions(+)

-- 
2.17.1

[PATCH v3 1/2] arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem

[Aswath Govindraju]

Add DT node for the single USB subsystem in main dtsi file.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 0cf727e3d1e2..7e7997e3adff 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -491,4 +491,34 @@
 		ti,cpts-periodic-outputs = <6>;
 		ti,cpts-ext-ts-inputs = <8>;
 	};
+
+	usbss0: cdns-usb@f900000{
+		compatible = "ti,am64-usb";
+		reg = <0x00 0xf900000 0x00 0x100>;
+		power-domains = <&k3_pds 161 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 161 9>, <&k3_clks 161 1>;
+		clock-names = "ref", "lpm";
+		assigned-clocks = <&k3_clks 161 9>; /* USB2_REFCLK */
+		assigned-clock-parents = <&k3_clks 161 10>; /* HF0SC0 */
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+		usb0: usb@f400000{
+			compatible = "cdns,usb3";
+			reg = <0x00 0xf400000 0x00 0x10000>,
+			      <0x00 0xf410000 0x00 0x10000>,
+			      <0x00 0xf420000 0x00 0x10000>;
+			reg-names = "otg",
+				    "xhci",
+				    "dev";
+			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */
+				     <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>, /* irq.6 */
+				     <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>; /* otgirq */
+			interrupt-names = "host",
+					  "peripheral",
+					  "otg";
+			maximum-speed = "super-speed";
+			dr_mode = "otg";
+		};
+	};
 };
-- 
2.17.1

[PATCH v3 2/2] arm64: dts: ti: k3-am642-evm: Add USB support

[Aswath Govindraju]

AM64 EVM board has a micro USB 2.0 AB connector and the USB0_VBUS is
connected with a resistor divider in between. USB0_DRVVBUS pin is muxed
between USB0_DRVVBUS and GPIO1_79 signals.

Add the corresponding properties and set the pinmux mode for USB subsystem
in the evm dts file.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 25fa6fbc0619..1365e3164294 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -210,6 +210,12 @@
 			AM64X_IOPAD(0x0144, PIN_OUTPUT, 4) /* (Y11) PRG1_PRU1_GPO15.RGMII2_TX_CTL */
 		>;
 	};
+
+	main_usb0_pins_default: main-usb0-pins-default {
+		pinctrl-single,pins = <
+			AM64X_IOPAD(0x02a8, PIN_OUTPUT, 0) /* (E19) USB0_DRVVBUS */
+		>;
+	};
 };
 
 &main_uart0 {
@@ -335,6 +341,18 @@
 	disable-wp;
 };
 
+&usbss0 {
+	ti,vbus-divider;
+	ti,usb2-only;
+};
+
+&usb0 {
+	dr_mode = "otg";
+	maximum-speed = "high-speed";
+	pinctrl-names = "default";
+	pinctrl-0 = <&main_usb0_pins_default>;
+};
+
 &cpsw3g {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mdio1_pins_default
-- 
2.17.1

Re: [PATCH v3 0/2] AM64: Add USB support

[Kishon Vijay Abraham I]

Aswath and Nishanth,

On 17/03/21 10:00 am, Aswath Govindraju wrote:
> The following series of patches, add USB support for AM642 evm.
> 
> USB test logs,
> https://pastebin.ubuntu.com/p/YSQRBWGmzd/

Vinod has provided stable tag [1]
git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
tags/ti-serdes-for-5.13

This should unblock us from up-streaming SK along with this.

Thanks
Kishon

[1] -> http://lore.kernel.org/r/YFGjPNonIlA4Anar@vkoul-mobl.Dlink
> 
> Changes since v2:
> - dropped compatible string "ti,j721e-usb" leading to DT schema errors
> - Reran test logs
> - Couldn't pick up reviewed-by from kishon as a change was made in the
>   patch
> 
> Changes since v1:
> - Rebased the patches on top of ti-k3-dts-next
> - Added test logs
> 
> Aswath Govindraju (2):
>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>   arm64: dts: ti: k3-am642-evm: Add USB support
> 
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>  2 files changed, 48 insertions(+)
> 

Re: [PATCH v3 0/2] AM64: Add USB support

[Kishon Vijay Abraham I]

Hi,

On 17/03/21 8:22 pm, Kishon Vijay Abraham I wrote:
> Aswath and Nishanth,
> 
> On 17/03/21 10:00 am, Aswath Govindraju wrote:
>> The following series of patches, add USB support for AM642 evm.
>>
>> USB test logs,
>> https://pastebin.ubuntu.com/p/YSQRBWGmzd/
> 
> Vinod has provided stable tag [1]
> git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
> tags/ti-serdes-for-5.13
> 
> This should unblock us from up-streaming SK along with this.

In case you prefer to send SK support as follow up patches

Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>

Thanks
Kishon

> 
> Thanks
> Kishon
> 
> [1] -> http://lore.kernel.org/r/YFGjPNonIlA4Anar@vkoul-mobl.Dlink
>>
>> Changes since v2:
>> - dropped compatible string "ti,j721e-usb" leading to DT schema errors
>> - Reran test logs
>> - Couldn't pick up reviewed-by from kishon as a change was made in the
>>   patch
>>
>> Changes since v1:
>> - Rebased the patches on top of ti-k3-dts-next
>> - Added test logs
>>
>> Aswath Govindraju (2):
>>   arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
>>   arm64: dts: ti: k3-am642-evm: Add USB support
>>
>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 30 ++++++++++++++++++++++++
>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 18 ++++++++++++++
>>  2 files changed, 48 insertions(+)
>>

Re: [PATCH v3 0/2] AM64: Add USB support

[Nishanth Menon]

On Wed, 17 Mar 2021 10:00:04 +0530, Aswath Govindraju wrote:
> The following series of patches, add USB support for AM642 evm.
> 
> USB test logs,
> https://pastebin.ubuntu.com/p/YSQRBWGmzd/
> 
> Changes since v2:
> - dropped compatible string "ti,j721e-usb" leading to DT schema errors
> - Reran test logs
> - Couldn't pick up reviewed-by from kishon as a change was made in the
>   patch
> 
> [...]

Hi Aswath Govindraju,

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem
      commit: d06a661309d30b654b74a4633dd78804ef16369f
[2/2] arm64: dts: ti: k3-am642-evm: Add USB support
      commit: 04a80a75baa1c80f7e5096147b6173c13ca3d3e0


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 0/2] AM64: Add USB support

[Nishanth Menon]

On 20:22-20210317, Kishon Vijay Abraham I wrote:
> Aswath and Nishanth,
> 
> On 17/03/21 10:00 am, Aswath Govindraju wrote:
> > The following series of patches, add USB support for AM642 evm.
> > 
> > USB test logs,
> > https://pastebin.ubuntu.com/p/YSQRBWGmzd/
> 
> Vinod has provided stable tag [1]
> git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
> tags/ti-serdes-for-5.13
> 
> This should unblock us from up-streaming SK along with this.
> 

Awesome. Thanks Vinod and Kishon for helping co-ordinate this.

Ashwath,

Please highlight this detail as part SK USB3 addendum series and I can
pick it up as part of pulling that series in. our window is starting to
narrow, so lets respin asap.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D