* [PATCH] drm/etnaviv: Remove redundant NULL check
@ 2021-03-23 2:46 Jiapeng Chong
2021-03-23 11:39 ` Christian Gmeiner
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-23 2:46 UTC (permalink / raw)
To: l.stach
Cc: linux+etnaviv, christian.gmeiner, airlied, daniel, sumit.semwal,
christian.koenig, etnaviv, dri-devel, linux-kernel, linux-media,
linaro-mm-sig, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL
check before some freeing functions is not needed.
./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL
check before some freeing functions is not needed.
./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL
check before some freeing functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index d05c359..bd0d66e 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
err_submit_cmds:
if (ret && (out_fence_fd >= 0))
put_unused_fd(out_fence_fd);
- if (stream)
- kvfree(stream);
- if (bos)
- kvfree(bos);
- if (relocs)
- kvfree(relocs);
- if (pmrs)
- kvfree(pmrs);
+ kvfree(stream);
+ kvfree(bos);
+ kvfree(relocs);
+ kvfree(pmrs);
return ret;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/etnaviv: Remove redundant NULL check
2021-03-23 2:46 [PATCH] drm/etnaviv: Remove redundant NULL check Jiapeng Chong
@ 2021-03-23 11:39 ` Christian Gmeiner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Gmeiner @ 2021-03-23 11:39 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter,
Sumit Semwal, Christian König, The etnaviv authors,
DRI mailing list, LKML, Linux Media Mailing List,
Linaro MM SIG Mailman List
Am Di., 23. März 2021 um 03:46 Uhr schrieb Jiapeng Chong
<jiapeng.chong@linux.alibaba.com>:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 2:46 [PATCH] drm/etnaviv: Remove redundant NULL check Jiapeng Chong
2021-03-23 11:39 ` Christian Gmeiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).