* [PATCH] uacce: fixup coding style
@ 2021-03-24 8:11 Kai Ye
2021-03-24 8:46 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Kai Ye @ 2021-03-24 8:11 UTC (permalink / raw)
To: gregkh, linux-accelerators, linux-kernel, linuxarm, zhangfei.gao,
wangzhou1, yekai13
delete invalid and redundant variable initialization.
Signed-off-by: Kai Ye <yekai13@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
---
drivers/misc/uacce/uacce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index d07af4e..94843e0 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -126,7 +126,7 @@ static int uacce_fops_open(struct inode *inode, struct file *filep)
{
struct uacce_device *uacce;
struct uacce_queue *q;
- int ret = 0;
+ int ret;
uacce = xa_load(&uacce_xa, iminor(inode));
if (!uacce)
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] uacce: fixup coding style
2021-03-24 8:11 [PATCH] uacce: fixup coding style Kai Ye
@ 2021-03-24 8:46 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-03-24 8:46 UTC (permalink / raw)
To: Kai Ye
Cc: linux-accelerators, linux-kernel, linuxarm, zhangfei.gao, wangzhou1
On Wed, Mar 24, 2021 at 04:11:55PM +0800, Kai Ye wrote:
> delete invalid and redundant variable initialization.
Why is it "invalid"? Seems to just not be needed.
And this isn't a coding style issue, your subject line is incorrect :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 8:11 [PATCH] uacce: fixup coding style Kai Ye
2021-03-24 8:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).