* [PATCH net-next v2] net: netcp: fix PM reference leak in netcp_probe()
@ 2021-03-27 10:28 Huang Guobin
0 siblings, 0 replies; only message in thread
From: Huang Guobin @ 2021-03-27 10:28 UTC (permalink / raw)
To: huangguobin4, Wingman Kwok, Murali Karicheri, David S. Miller,
Jakub Kicinski
Cc: netdev, linux-kernel
From: Guobin Huang <huangguobin4@huawei.com>
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
drivers/net/ethernet/ti/netcp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index d7a144b4a09f..0675f259033e 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -2171,7 +2171,7 @@ static int netcp_probe(struct platform_device *pdev)
return -ENOMEM;
pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0) {
dev_err(dev, "Failed to enable NETCP power-domain\n");
pm_runtime_disable(&pdev->dev);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-27 10:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 10:28 [PATCH net-next v2] net: netcp: fix PM reference leak in netcp_probe() Huang Guobin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).