* [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()
@ 2021-03-31 9:32 Qiheng Lin
2021-04-01 17:57 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Qiheng Lin @ 2021-03-31 9:32 UTC (permalink / raw)
To: linqiheng, Krzysztof Kozlowski; +Cc: linux-kernel, kernel-janitors, Hulk Robot
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/memory/fsl-corenet-cf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c
index 0309bd5a1800..e15c962d4540 100644
--- a/drivers/memory/fsl-corenet-cf.c
+++ b/drivers/memory/fsl-corenet-cf.c
@@ -192,10 +192,8 @@ static int ccf_probe(struct platform_device *pdev)
}
ccf->regs = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(ccf->regs)) {
- dev_err(&pdev->dev, "%s: can't map mem resource\n", __func__);
+ if (IS_ERR(ccf->regs))
return PTR_ERR(ccf->regs);
- }
ccf->dev = &pdev->dev;
ccf->info = match->data;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()
2021-03-31 9:32 [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe() Qiheng Lin
@ 2021-04-01 17:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-01 17:57 UTC (permalink / raw)
To: Qiheng Lin; +Cc: Krzysztof Kozlowski, linux-kernel, Hulk Robot, kernel-janitors
On Wed, 31 Mar 2021 17:32:44 +0800, Qiheng Lin wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied, thanks!
[1/1] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe()
commit: b11a188aef6d19fe3ca505831d9c627ef683476f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-01 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 9:32 [PATCH -next] memory: fsl-corenet-cf: Remove redundant dev_err call in ccf_probe() Qiheng Lin
2021-04-01 17:57 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).