* [PATCH v2] crypto: hisilicon/qm - delete redundant code
@ 2021-04-02 11:22 Kai Ye
2021-04-09 7:55 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Kai Ye @ 2021-04-02 11:22 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, linux-kernel, wangzhou1, yekai13
The "qdma" is a structure variable instead of actual data. This
structure doesn't need to be zerod, The memset is useless and redundant.
So delete it.
Signed-off-by: Kai Ye <yekai13@huawei.com>
---
Changes v1 -> v2:
Re-edit the description.
drivers/crypto/hisilicon/qm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 13cb421..88a6c6f 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -2527,7 +2527,6 @@ void hisi_qm_uninit(struct hisi_qm *qm)
hisi_qm_cache_wb(qm);
dma_free_coherent(dev, qm->qdma.size,
qm->qdma.va, qm->qdma.dma);
- memset(&qm->qdma, 0, sizeof(qm->qdma));
}
qm_irq_unregister(qm);
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: hisilicon/qm - delete redundant code
2021-04-02 11:22 [PATCH v2] crypto: hisilicon/qm - delete redundant code Kai Ye
@ 2021-04-09 7:55 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-04-09 7:55 UTC (permalink / raw)
To: Kai Ye; +Cc: linux-crypto, linux-kernel, wangzhou1
On Fri, Apr 02, 2021 at 07:22:30PM +0800, Kai Ye wrote:
> The "qdma" is a structure variable instead of actual data. This
> structure doesn't need to be zerod, The memset is useless and redundant.
> So delete it.
>
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> ---
> Changes v1 -> v2:
> Re-edit the description.
>
> drivers/crypto/hisilicon/qm.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 11:22 [PATCH v2] crypto: hisilicon/qm - delete redundant code Kai Ye
2021-04-09 7:55 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).