* [tip: core/rcu] rcu: Remove spurious instrumentation_end() in rcu_nmi_enter()
@ 2021-04-11 13:43 tip-bot2 for Zhouyi Zhou
0 siblings, 0 replies; only message in thread
From: tip-bot2 for Zhouyi Zhou @ 2021-04-11 13:43 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Zhouyi Zhou, Paul E. McKenney, x86, linux-kernel
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 6494ccb93271bee596a12db32ff44867d5be2321
Gitweb: https://git.kernel.org/tip/6494ccb93271bee596a12db32ff44867d5be2321
Author: Zhouyi Zhou <zhouzhouyi@gmail.com>
AuthorDate: Mon, 11 Jan 2021 09:08:59 +08:00
Committer: Paul E. McKenney <paulmck@kernel.org>
CommitterDate: Mon, 08 Mar 2021 14:17:35 -08:00
rcu: Remove spurious instrumentation_end() in rcu_nmi_enter()
In rcu_nmi_enter(), there is an erroneous instrumentation_end() in the
second branch of the "if" statement. Oddly enough, "objtool check -f
vmlinux.o" fails to complain because it is unable to correctly cover
all cases. Instead, objtool visits the third branch first, which marks
following trace_rcu_dyntick() as visited. This commit therefore removes
the spurious instrumentation_end().
Fixes: 04b25a495bd6 ("rcu: Mark rcu_nmi_enter() call to rcu_cleanup_after_idle() noinstr")
Reported-by Neeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/tree.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index e62c2de..4d90f20 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1076,7 +1076,6 @@ noinstr void rcu_nmi_enter(void)
} else if (!in_nmi()) {
instrumentation_begin();
rcu_irq_enter_check_tick();
- instrumentation_end();
} else {
instrumentation_begin();
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-11 13:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11 13:43 [tip: core/rcu] rcu: Remove spurious instrumentation_end() in rcu_nmi_enter() tip-bot2 for Zhouyi Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).