[PATCH] x86: Ensure asm/proto.h can be included stand-alone

[PATCH] x86: Ensure asm/proto.h can be included stand-alone

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Avoids

../arch/x86/include/asm/proto.h:14:30: warning: ‘struct task_struct’ declared inside parameter list will not be visible outside of this definition or declaration
 long do_arch_prctl_64(struct task_struct *task, int option, unsigned long arg2);
                              ^~~~~~~~~~~
../arch/x86/include/asm/proto.h:40:34: warning: ‘struct task_struct’ declared inside parameter list will not be visible outside of this definition or declaration
 long do_arch_prctl_common(struct task_struct *task, int option,
                                  ^~~~~~~~~~~

if linux/sched.h hasn't be included previously.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/x86/include/asm/proto.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h
index b6a9d51d1d79..8c5d1910a848 100644
--- a/arch/x86/include/asm/proto.h
+++ b/arch/x86/include/asm/proto.h
@@ -4,6 +4,8 @@

 #include <asm/ldt.h>

+struct task_struct;
+
 /* misc architecture specific prototypes */

 void syscall_init(void);
--
2.26.2

[tip: x86/cleanups] x86/asm: Ensure asm/proto.h can be included stand-alone

[tip-bot2 for Jan Kiszka]

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     f7b21a0e41171d22296b897dac6e4c41d2a3643c
Gitweb:        https://git.kernel.org/tip/f7b21a0e41171d22296b897dac6e4c41d2a3643c
Author:        Jan Kiszka <jan.kiszka@siemens.com>
AuthorDate:    Sun, 11 Apr 2021 10:12:16 +02:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 12 Apr 2021 13:12:46 +02:00

x86/asm: Ensure asm/proto.h can be included stand-alone

Fix:

  ../arch/x86/include/asm/proto.h:14:30: warning: ‘struct task_struct’ declared \
    inside parameter list will not be visible outside of this definition or declaration
  long do_arch_prctl_64(struct task_struct *task, int option, unsigned long arg2);
                               ^~~~~~~~~~~

  .../arch/x86/include/asm/proto.h:40:34: warning: ‘struct task_struct’ declared \
    inside parameter list will not be visible outside of this definition or declaration
   long do_arch_prctl_common(struct task_struct *task, int option,
                                    ^~~~~~~~~~~

if linux/sched.h hasn't be included previously. This fixes a build error
when this header is used outside of the kernel tree.

 [ bp: Massage commit message. ]

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/b76b4be3-cf66-f6b2-9a6c-3e7ef54f9845@web.de
---
 arch/x86/include/asm/proto.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h
index b6a9d51..8c5d191 100644
--- a/arch/x86/include/asm/proto.h
+++ b/arch/x86/include/asm/proto.h
@@ -4,6 +4,8 @@
 
 #include <asm/ldt.h>
 
+struct task_struct;
+
 /* misc architecture specific prototypes */
 
 void syscall_init(void);