* [PATCH] virtiofs: remove useless function
@ 2021-04-13 9:22 Jiapeng Chong
2021-04-14 8:40 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-13 9:22 UTC (permalink / raw)
To: vgoyal
Cc: stefanha, miklos, virtualization, linux-fsdevel, linux-kernel,
Jiapeng Chong
Fix the following clang warning:
fs/fuse/virtio_fs.c:130:35: warning: unused function 'vq_to_fpq'
[-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/fuse/virtio_fs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 4ee6f73..630da49 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -127,11 +127,6 @@ static inline struct virtio_fs_vq *vq_to_fsvq(struct virtqueue *vq)
return &fs->vqs[vq->index];
}
-static inline struct fuse_pqueue *vq_to_fpq(struct virtqueue *vq)
-{
- return &vq_to_fsvq(vq)->fud->pq;
-}
-
/* Should be called with fsvq->lock held. */
static inline void inc_in_flight_req(struct virtio_fs_vq *fsvq)
{
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtiofs: remove useless function
2021-04-13 9:22 [PATCH] virtiofs: remove useless function Jiapeng Chong
@ 2021-04-14 8:40 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2021-04-14 8:40 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: vgoyal, miklos, virtualization, linux-fsdevel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Tue, Apr 13, 2021 at 05:22:23PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> fs/fuse/virtio_fs.c:130:35: warning: unused function 'vq_to_fpq'
> [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/fuse/virtio_fs.c | 5 -----
> 1 file changed, 5 deletions(-)
The function was never used...
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-14 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 9:22 [PATCH] virtiofs: remove useless function Jiapeng Chong
2021-04-14 8:40 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).