* [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static
@ 2021-04-07 12:57 Yu Kuai
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Yu Kuai @ 2021-04-07 12:57 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, linux-kernel, yukuai3, yi.zhang, zhangxiaoxu5
The sparse tool complains as follows:
drivers/macintosh/windfarm_pm121.c:436:24: warning:
symbol 'pm121_sys_state' was not declared. Should it be static?
This symbol is not used outside of windfarm_pm121.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/macintosh/windfarm_pm121.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
index ab467b9c31be..ba1ec6fc11d2 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -433,7 +433,7 @@ struct pm121_sys_state {
struct wf_pid_state pid;
};
-struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {};
+static struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {};
/*
* ****** CPU Fans Control Loop ******
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static
2021-04-07 12:57 [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static Yu Kuai
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Yu Kuai, benh; +Cc: zhangxiaoxu5, yi.zhang, linuxppc-dev, linux-kernel
On Wed, 7 Apr 2021 20:57:12 +0800, Yu Kuai wrote:
> The sparse tool complains as follows:
>
> drivers/macintosh/windfarm_pm121.c:436:24: warning:
> symbol 'pm121_sys_state' was not declared. Should it be static?
>
> This symbol is not used outside of windfarm_pm121.c, so this
> commit marks it static.
Applied to powerpc/next.
[1/1] macintosh/windfarm: Make symbol 'pm121_sys_state' static
https://git.kernel.org/powerpc/c/13ddd0e3acf988a98b46800178ae691640b0cd00
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 4:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 12:57 [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static Yu Kuai
2021-04-19 3:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).