* [PATCH] net/tls: Remove redundant initialization of record
@ 2021-04-27 10:28 Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-27 10:28 UTC (permalink / raw)
To: borisp
Cc: john.fastabend, daniel, kuba, davem, netdev, linux-kernel, Jiapeng Chong
record is being initialized to ctx->open_record but this is never
read as record is overwritten later on. Remove the redundant
initialization.
Cleans up the following clang-analyzer warning:
net/tls/tls_device.c:421:26: warning: Value stored to 'record' during
its initialization is never read [clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
net/tls/tls_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index d9cd229..72227fe 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -418,7 +418,7 @@ static int tls_push_data(struct sock *sk,
struct tls_context *tls_ctx = tls_get_ctx(sk);
struct tls_prot_info *prot = &tls_ctx->prot_info;
struct tls_offload_context_tx *ctx = tls_offload_ctx_tx(tls_ctx);
- struct tls_record_info *record = ctx->open_record;
+ struct tls_record_info *record;
int tls_push_record_flags;
struct page_frag *pfrag;
size_t orig_size = size;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/tls: Remove redundant initialization of record
2021-04-27 10:28 [PATCH] net/tls: Remove redundant initialization of record Jiapeng Chong
@ 2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-27 21:22 UTC (permalink / raw)
To: Jiapeng Chong
Cc: borisp, john.fastabend, daniel, kuba, davem, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 27 Apr 2021 18:28:22 +0800 you wrote:
> record is being initialized to ctx->open_record but this is never
> read as record is overwritten later on. Remove the redundant
> initialization.
>
> Cleans up the following clang-analyzer warning:
>
> net/tls/tls_device.c:421:26: warning: Value stored to 'record' during
> its initialization is never read [clang-analyzer-deadcode.DeadStores].
>
> [...]
Here is the summary with links:
- net/tls: Remove redundant initialization of record
https://git.kernel.org/netdev/net-next/c/3afef8c7aa2d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-27 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 10:28 [PATCH] net/tls: Remove redundant initialization of record Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).