* [PATCH] llc2: Remove redundant assignment to rc
@ 2021-04-27 10:29 Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-27 10:29 UTC (permalink / raw)
To: davem; +Cc: kuba, netdev, linux-kernel, Jiapeng Chong
Variable rc is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Cleans up the following clang-analyzer warning:
net/llc/llc_station.c:86:2: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
net/llc/llc_station.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/llc/llc_station.c b/net/llc/llc_station.c
index c29170e..05c6ae0 100644
--- a/net/llc/llc_station.c
+++ b/net/llc/llc_station.c
@@ -54,7 +54,6 @@ static int llc_station_ac_send_xid_r(struct sk_buff *skb)
if (!nskb)
goto out;
- rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
@@ -83,7 +82,6 @@ static int llc_station_ac_send_test_r(struct sk_buff *skb)
if (!nskb)
goto out;
- rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] llc2: Remove redundant assignment to rc
2021-04-27 10:29 [PATCH] llc2: Remove redundant assignment to rc Jiapeng Chong
@ 2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-27 21:22 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 27 Apr 2021 18:29:48 +0800 you wrote:
> Variable rc is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/llc/llc_station.c:86:2: warning: Value stored to 'rc' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> [...]
Here is the summary with links:
- llc2: Remove redundant assignment to rc
https://git.kernel.org/netdev/net-next/c/2342eb1afe00
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] llc2: Remove redundant assignment to rc
@ 2021-04-28 10:00 Yang Li
0 siblings, 0 replies; 3+ messages in thread
From: Yang Li @ 2021-04-28 10:00 UTC (permalink / raw)
To: davem
Cc: kuba, nathan, ndesaulniers, netdev, linux-kernel,
clang-built-linux, Yang Li
Variable 'rc' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Cleans up the following clang-analyzer warning:
net/llc/llc_station.c:54:2: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores]
net/llc/llc_station.c:83:2: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/llc/llc_station.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/llc/llc_station.c b/net/llc/llc_station.c
index c29170e..05c6ae0 100644
--- a/net/llc/llc_station.c
+++ b/net/llc/llc_station.c
@@ -54,7 +54,6 @@ static int llc_station_ac_send_xid_r(struct sk_buff *skb)
if (!nskb)
goto out;
- rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
@@ -83,7 +82,6 @@ static int llc_station_ac_send_test_r(struct sk_buff *skb)
if (!nskb)
goto out;
- rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-28 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 10:29 [PATCH] llc2: Remove redundant assignment to rc Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
2021-04-28 10:00 Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).