* [PATCH] net/smc: Remove redundant assignment to rc
@ 2021-04-27 10:32 Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-27 10:32 UTC (permalink / raw)
To: kgraul; +Cc: davem, kuba, linux-s390, netdev, linux-kernel, Jiapeng Chong
Variable rc is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Cleans up the following clang-analyzer warning:
net/smc/af_smc.c:1079:3: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
net/smc/af_smc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 47340b3..be3e80b 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1076,7 +1076,6 @@ static int smc_connect(struct socket *sock, struct sockaddr *addr,
rc = -EISCONN;
goto out;
case SMC_INIT:
- rc = 0;
break;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/smc: Remove redundant assignment to rc
2021-04-27 10:32 [PATCH] net/smc: Remove redundant assignment to rc Jiapeng Chong
@ 2021-04-27 21:22 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-27 21:22 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: kgraul, davem, kuba, linux-s390, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 27 Apr 2021 18:32:22 +0800 you wrote:
> Variable rc is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/smc/af_smc.c:1079:3: warning: Value stored to 'rc' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> [...]
Here is the summary with links:
- net/smc: Remove redundant assignment to rc
https://git.kernel.org/netdev/net-next/c/6fd6c483e7ab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-27 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 10:32 [PATCH] net/smc: Remove redundant assignment to rc Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).