linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rds: Remove redundant assignment to nr_sig
@ 2021-04-27 10:24 Jiapeng Chong
  2021-04-27 21:22 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-27 10:24 UTC (permalink / raw)
  To: santosh.shilimkar
  Cc: davem, kuba, netdev, inux-rdma, rds-devel, linux-kernel, Jiapeng Chong

Variable nr_sig is being assigned a value however the assignment is
never read, so this redundant assignment can be removed.

Cleans up the following clang-analyzer warning:

net/rds/ib_send.c:297:2: warning: Value stored to 'nr_sig' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 net/rds/ib_send.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 92b4a86..4190b90 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -294,7 +294,6 @@ void rds_ib_send_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc)
 
 	rds_ib_ring_free(&ic->i_send_ring, completed);
 	rds_ib_sub_signaled(ic, nr_sig);
-	nr_sig = 0;
 
 	if (test_and_clear_bit(RDS_LL_SEND_FULL, &conn->c_flags) ||
 	    test_bit(0, &conn->c_map_queued))
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rds: Remove redundant assignment to nr_sig
  2021-04-27 10:24 [PATCH] rds: Remove redundant assignment to nr_sig Jiapeng Chong
@ 2021-04-27 21:22 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-27 21:22 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: santosh.shilimkar, davem, kuba, netdev, inux-rdma, rds-devel,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 27 Apr 2021 18:24:47 +0800 you wrote:
> Variable nr_sig is being assigned a value however the assignment is
> never read, so this redundant assignment can be removed.
> 
> Cleans up the following clang-analyzer warning:
> 
> net/rds/ib_send.c:297:2: warning: Value stored to 'nr_sig' is never read
> [clang-analyzer-deadcode.DeadStores].
> 
> [...]

Here is the summary with links:
  - rds: Remove redundant assignment to nr_sig
    https://git.kernel.org/netdev/net-next/c/4db6187d721e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-27 21:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 10:24 [PATCH] rds: Remove redundant assignment to nr_sig Jiapeng Chong
2021-04-27 21:22 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).