From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dario Binacchi <dariobin@libero.it>, linux-kernel@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG
Date: Thu, 29 Apr 2021 23:29:49 +0200 [thread overview]
Message-ID: <161973168395.2582973.9374098143035295509.b4-ty@bootlin.com> (raw)
In-Reply-To: <20210425145924.23353-1-dariobin@libero.it>
On Sun, 25 Apr 2021 16:59:23 +0200, Dario Binacchi wrote:
> The RTC_OSC_REG register is 32-bit, but the useful information is found
> in the 7 least significant bits (bits 7-31 are reserved). And in fact,
> as you can see from the code, all read accesses are 8-bit, as well as
> some writes. Let's make sure all writes are 8-bit. Moreover, in contexts
> where consecutive reads / writes after the busy check must take place
> within 15 us, it is better not to waste time on useless accesses.
I really doubt writeb versus writel actually make a difference as the bus will
probably still do a 32bit access.
Applied, thanks!
[1/1] rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG
commit: 50f2cc7f758cdbc7c8f928edc25b1c7bc09ef3e2
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2021-04-29 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 14:59 [PATCH] rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG Dario Binacchi
2021-04-29 21:29 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161973168395.2582973.9374098143035295509.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=dariobin@libero.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).