* [PATCH] vsock/vmci: Remove redundant assignment to err
@ 2021-04-30 9:27 Yang Li
2021-04-30 22:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-04-30 9:27 UTC (permalink / raw)
To: davem
Cc: kuba, nathan, ndesaulniers, netdev, linux-kernel,
clang-built-linux, Yang Li
Variable 'err' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Clean up the following clang-analyzer warning:
net/vmw_vsock/vmci_transport.c:948:2: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/vmw_vsock/vmci_transport.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index 1c9ecb1..c99bc4c 100644
--- a/net/vmw_vsock/vmci_transport.c
+++ b/net/vmw_vsock/vmci_transport.c
@@ -944,8 +944,6 @@ static int vmci_transport_recv_listen(struct sock *sk,
bool old_request = false;
bool old_pkt_proto = false;
- err = 0;
-
/* Because we are in the listen state, we could be receiving a packet
* for ourself or any previous connection requests that we received.
* If it's the latter, we try to find a socket in our list of pending
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vsock/vmci: Remove redundant assignment to err
2021-04-30 9:27 [PATCH] vsock/vmci: Remove redundant assignment to err Yang Li
@ 2021-04-30 22:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-30 22:10 UTC (permalink / raw)
To: Yang Li
Cc: davem, kuba, nathan, ndesaulniers, netdev, linux-kernel,
clang-built-linux
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 30 Apr 2021 17:27:34 +0800 you wrote:
> Variable 'err' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> net/vmw_vsock/vmci_transport.c:948:2: warning: Value stored to 'err' is
> never read [clang-analyzer-deadcode.DeadStores]
>
> [...]
Here is the summary with links:
- vsock/vmci: Remove redundant assignment to err
https://git.kernel.org/netdev/net/c/f0a5818b472c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-30 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 9:27 [PATCH] vsock/vmci: Remove redundant assignment to err Yang Li
2021-04-30 22:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).