* [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S
@ 2021-04-26 11:46 Tianling Shen
2021-04-27 9:11 ` Pavel Machek
2021-05-09 23:55 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Tianling Shen @ 2021-04-26 11:46 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Pavel Machek, Johan Jonker,
Jagan Teki, Jacek Anaszewski, Geert Uytterhoeven,
Uwe Kleine-König, Marty Jones, Jensen Huang, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
However "sys" is not a valid function, and it is always on.
Let's keep existing functions.
Fixes: db792e9adbf85f ("rockchip: rk3399: Add support for FriendlyARM NanoPi R4S")
Suggested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
index fa5809887643..cef4d18b599d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
@@ -33,7 +33,7 @@
sys_led: led-sys {
gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
- label = "red:sys";
+ label = "red:power";
default-state = "on";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S
2021-04-26 11:46 [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S Tianling Shen
@ 2021-04-27 9:11 ` Pavel Machek
2021-05-09 23:55 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2021-04-27 9:11 UTC (permalink / raw)
To: Tianling Shen
Cc: Rob Herring, Heiko Stuebner, Johan Jonker, Jagan Teki,
Jacek Anaszewski, Geert Uytterhoeven, Uwe Kleine-König,
Marty Jones, Jensen Huang, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Mon 2021-04-26 19:46:52, Tianling Shen wrote:
> However "sys" is not a valid function, and it is always on.
> Let's keep existing functions.
>
> Fixes: db792e9adbf85f ("rockchip: rk3399: Add support for FriendlyARM NanoPi R4S")
>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S
2021-04-26 11:46 [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S Tianling Shen
2021-04-27 9:11 ` Pavel Machek
@ 2021-05-09 23:55 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2021-05-09 23:55 UTC (permalink / raw)
To: Marty Jones, Rob Herring, Pavel Machek, Jensen Huang,
Tianling Shen, Johan Jonker, Jagan Teki, Uwe Kleine-König,
Jacek Anaszewski, Geert Uytterhoeven
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip
On Mon, 26 Apr 2021 19:46:52 +0800, Tianling Shen wrote:
> However "sys" is not a valid function, and it is always on.
> Let's keep existing functions.
>
> Fixes: db792e9adbf85f ("rockchip: rk3399: Add support for FriendlyARM NanoPi R4S")
Applied, thanks!
[1/1] arm64: dts: rockchip: rename LED label for NanoPi R4S
commit: 6a11ffc2cc54d89719d5b2f3ca44244cebd7ed2e
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-09 23:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 11:46 [PATCH] arm64: dts: rockchip: rename LED label for NanoPi R4S Tianling Shen
2021-04-27 9:11 ` Pavel Machek
2021-05-09 23:55 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).