* [PATCH] ALSA: hda: generic: Remove redundant assignment to dac and dacs[i]
@ 2021-05-10 10:41 Jiapeng Chong
2021-05-10 10:57 ` Amadeusz Sławiński
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-10 10:41 UTC (permalink / raw)
To: perex; +Cc: tiwai, alsa-devel, linux-kernel, Jiapeng Chong
Variable dac and dacs[i] is set to zero, but this value is never read as
it is overwritten or not used later on, hence it is a redundant assignment
and can be removed.
Clean up the following clang-analyzer warning:
sound/pci/hda/hda_generic.c:1436:4: warning: Value stored to 'dac' is
never read [clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/pci/hda/hda_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index b638fc2..cce1bf7 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -1433,7 +1433,6 @@ static int try_assign_dacs(struct hda_codec *codec, int num_outs,
path = snd_hda_add_new_path(codec, dac, pin, 0);
}
if (!path) {
- dac = dacs[i] = 0;
badness += bad->no_dac;
} else {
/* print_nid_path(codec, "output", path); */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: generic: Remove redundant assignment to dac and dacs[i]
2021-05-10 10:41 [PATCH] ALSA: hda: generic: Remove redundant assignment to dac and dacs[i] Jiapeng Chong
@ 2021-05-10 10:57 ` Amadeusz Sławiński
0 siblings, 0 replies; 2+ messages in thread
From: Amadeusz Sławiński @ 2021-05-10 10:57 UTC (permalink / raw)
To: Jiapeng Chong, perex; +Cc: alsa-devel, tiwai, linux-kernel
On 5/10/2021 12:41 PM, Jiapeng Chong wrote:
> Variable dac and dacs[i] is set to zero, but this value is never read as
> it is overwritten or not used later on, hence it is a redundant assignment
> and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> sound/pci/hda/hda_generic.c:1436:4: warning: Value stored to 'dac' is
> never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> sound/pci/hda/hda_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
> index b638fc2..cce1bf7 100644
> --- a/sound/pci/hda/hda_generic.c
> +++ b/sound/pci/hda/hda_generic.c
> @@ -1433,7 +1433,6 @@ static int try_assign_dacs(struct hda_codec *codec, int num_outs,
> path = snd_hda_add_new_path(codec, dac, pin, 0);
> }
> if (!path) {
> - dac = dacs[i] = 0;
> badness += bad->no_dac;
> } else {
> /* print_nid_path(codec, "output", path); */
>
Not entirely true... dacs is passed by pointer, so value assigned to it
can be used somewhere else.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 10:41 [PATCH] ALSA: hda: generic: Remove redundant assignment to dac and dacs[i] Jiapeng Chong
2021-05-10 10:57 ` Amadeusz Sławiński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).