* [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema
@ 2021-05-05 13:59 Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100 Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-05 13:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
The Broadcom BCM4329 family dtschema expects devices to be compatible
also with brcm,bcm4329-fmac:
arch/arm/boot/dts/exynos3250-rinato.dt.yaml: wifi@1: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm4334-fmac'] is too short
'brcm,bcm4329-fmac' was expected
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
arch/arm/boot/dts/exynos4210-i9100.dts | 2 +-
arch/arm/boot/dts/exynos4210-trats.dts | 2 +-
arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index c52b9cf4f74c..f6ba5e426040 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -653,7 +653,7 @@ &mshc_1 {
mmc-pwrseq = <&wlan_pwrseq>;
brcmf: wifi@1 {
- compatible = "brcm,bcm4334-fmac";
+ compatible = "brcm,bcm4334-fmac", "brcm,bcm4329-fmac";
reg = <1>;
interrupt-parent = <&gpx1>;
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
index 525ff3d2fac3..db70f62cc08f 100644
--- a/arch/arm/boot/dts/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/exynos4210-i9100.dts
@@ -806,7 +806,7 @@ &sdhci_3 {
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
brcmf: wifi@1 {
- compatible = "brcm,bcm4330-fmac";
+ compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
reg = <1>;
interrupt-parent = <&gpx2>;
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index d2406c9146b8..3eb8df319246 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -521,7 +521,7 @@ &sdhci_3 {
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
brcmf: wifi@1 {
- compatible = "brcm,bcm4330-fmac";
+ compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
reg = <1>;
interrupt-parent = <&gpx2>;
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index dd44ad2c6ad6..f052853244a4 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -614,7 +614,7 @@ &sdhci_3 {
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
brcmf: wifi@1 {
- compatible = "brcm,bcm4330-fmac";
+ compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
reg = <1>;
interrupt-parent = <&gpx2>;
interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
@ 2021-05-05 13:59 ` Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3 Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-05 13:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Replace legacy MMS114 touchscreen properties to fix dtschema warnings:
arch/arm/boot/dts/exynos4412-n710x.dt.yaml: touchscreen@48:
'x-size', 'y-size' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/exynos4412-n710x.dt.yaml: touchscreen@48:
'touchscreen-size-x' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos4412-n710x.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-n710x.dts b/arch/arm/boot/dts/exynos4412-n710x.dts
index c49dbb7847b8..2c792142605c 100644
--- a/arch/arm/boot/dts/exynos4412-n710x.dts
+++ b/arch/arm/boot/dts/exynos4412-n710x.dts
@@ -50,8 +50,8 @@ touchscreen@48 {
reg = <0x48>;
interrupt-parent = <&gpm2>;
interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
- x-size = <720>;
- y-size = <1280>;
+ touchscreen-size-x = <720>;
+ touchscreen-size-y = <1280>;
avdd-supply = <&ldo23_reg>;
vdd-supply = <&ldo24_reg>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100 Krzysztof Kozlowski
@ 2021-05-05 13:59 ` Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 4/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1 Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-05 13:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
There is no "max_brightness" property. This brings the intentional
brightness reduce of green LED and dtschema checks as well:
arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: led-controller-1: led-1: 'max-brightness' is a required property
Fixes: 719f39fec586 ("ARM: dts: exynos5422-odroidxu3: Hook up PWM and use it for LEDs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
index 2fc3e86dc5f7..982752e1df24 100644
--- a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
+++ b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
@@ -22,7 +22,7 @@ led-1 {
* Green LED is much brighter than the others
* so limit its max brightness
*/
- max_brightness = <127>;
+ max-brightness = <127>;
linux,default-trigger = "mmc0";
};
@@ -30,7 +30,7 @@ led-2 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
- max_brightness = <255>;
+ max-brightness = <255>;
linux,default-trigger = "heartbeat";
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100 Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3 Krzysztof Kozlowski
@ 2021-05-05 13:59 ` Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4 Krzysztof Kozlowski
2021-05-11 12:36 ` [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-05 13:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
There is no "max_brightness" property as pointed out by dtschema:
arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml: led-controller: led-1: 'max-brightness' is a required property
Fixes: 1ac49427b566 ("ARM: dts: exynos: Add support for Hardkernel's Odroid HC1 board")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos5422-odroidhc1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidhc1.dts b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
index 20c222b33f98..d91f7fa2cf80 100644
--- a/arch/arm/boot/dts/exynos5422-odroidhc1.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
@@ -22,7 +22,7 @@ led-1 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
- max_brightness = <255>;
+ max-brightness = <255>;
linux,default-trigger = "heartbeat";
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
` (2 preceding siblings ...)
2021-05-05 13:59 ` [PATCH 4/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1 Krzysztof Kozlowski
@ 2021-05-05 13:59 ` Krzysztof Kozlowski
2021-05-11 12:36 ` [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-05 13:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
There is no "max_brightness" property as pointed out by dtschema:
arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: led-controller: led-1: 'max-brightness' is a required property
Fixes: 6658356014cb ("ARM: dts: Add support Odroid XU4 board for exynos5422-odroidxu4")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos5422-odroidxu4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
index ede782257643..1c24f9b35973 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
@@ -24,7 +24,7 @@ led-1 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
- max_brightness = <255>;
+ max-brightness = <255>;
linux,default-trigger = "heartbeat";
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
` (3 preceding siblings ...)
2021-05-05 13:59 ` [PATCH 5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4 Krzysztof Kozlowski
@ 2021-05-11 12:36 ` Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-11 12:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-kernel, Rob Herring, devicetree,
linux-samsung-soc, linux-kernel
On Wed, 5 May 2021 09:59:37 -0400, Krzysztof Kozlowski wrote:
> The Broadcom BCM4329 family dtschema expects devices to be compatible
> also with brcm,bcm4329-fmac:
>
> arch/arm/boot/dts/exynos3250-rinato.dt.yaml: wifi@1: compatible: 'oneOf' conditional failed, one must be fixed:
> ['brcm,bcm4334-fmac'] is too short
> 'brcm,bcm4329-fmac' was expected
Applied, thanks!
[1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema
commit: cc29e39412b9a78b43f7dfa09d739f8ba9fa7984
[2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100
commit: 8bceb2a490bb8e1048e9c73520f49a65823108a4
[3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3
commit: 75121e1dc9fe4def41e63d57f6a53749b88006ed
[4/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1
commit: a7e59c84cf2055a1894f45855c8319191f2fa59e
[5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4
commit: fd2f1717966535b7d0b6fe45cf0d79e94330da5f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-11 12:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 13:59 [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 2/5] ARM: dts: exynos: replace legacy MMS114 touchscreen x/y properties in GT-N7100 Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 3/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3 Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 4/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1 Krzysztof Kozlowski
2021-05-05 13:59 ` [PATCH 5/5] ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4 Krzysztof Kozlowski
2021-05-11 12:36 ` [PATCH 1/5] ARM: dts: exynos: align Broadcom WiFi with dtschema Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).