* [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12 3:17 Zou Wei
2021-05-12 11:28 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-05-12 3:17 UTC (permalink / raw)
To: linus.walleij, bgolaszewski; +Cc: linux-gpio, linux-kernel, Zou Wei
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/gpio/gpio-cadence.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c
index a4d3239..4ab3fcd 100644
--- a/drivers/gpio/gpio-cadence.c
+++ b/drivers/gpio/gpio-cadence.c
@@ -278,6 +278,7 @@ static const struct of_device_id cdns_of_ids[] = {
{ .compatible = "cdns,gpio-r1p02" },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, cdns_of_ids);
static struct platform_driver cdns_gpio_driver = {
.driver = {
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE
2021-05-12 3:17 [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE Zou Wei
@ 2021-05-12 11:28 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-12 11:28 UTC (permalink / raw)
To: Zou Wei; +Cc: Linus Walleij, linux-gpio, LKML
On Wed, May 12, 2021 at 5:01 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/gpio/gpio-cadence.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c
> index a4d3239..4ab3fcd 100644
> --- a/drivers/gpio/gpio-cadence.c
> +++ b/drivers/gpio/gpio-cadence.c
> @@ -278,6 +278,7 @@ static const struct of_device_id cdns_of_ids[] = {
> { .compatible = "cdns,gpio-r1p02" },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, cdns_of_ids);
>
> static struct platform_driver cdns_gpio_driver = {
> .driver = {
> --
> 2.6.2
>
The tag should be just regular [PATCH] as this driver has been
upstream for a long time.
Applied for fixes, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 3:17 [PATCH -next] gpio: cadence: Add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 11:28 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).