* [PATCH] regulator: cros-ec: Fix error code in dev_err message
@ 2021-05-12 7:58 Axel Lin
2021-05-12 17:04 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2021-05-12 7:58 UTC (permalink / raw)
To: Mark Brown; +Cc: Pi-Hsun Shih, Liam Girdwood, linux-kernel, Axel Lin
Show proper error code instead of 0.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/cros-ec-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/cros-ec-regulator.c b/drivers/regulator/cros-ec-regulator.c
index eb3fc1db4edc..c4754f3cf233 100644
--- a/drivers/regulator/cros-ec-regulator.c
+++ b/drivers/regulator/cros-ec-regulator.c
@@ -225,8 +225,9 @@ static int cros_ec_regulator_probe(struct platform_device *pdev)
drvdata->dev = devm_regulator_register(dev, &drvdata->desc, &cfg);
if (IS_ERR(drvdata->dev)) {
+ ret = PTR_ERR(drvdata->dev);
dev_err(&pdev->dev, "Failed to register regulator: %d\n", ret);
- return PTR_ERR(drvdata->dev);
+ return ret;
}
platform_set_drvdata(pdev, drvdata);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: cros-ec: Fix error code in dev_err message
2021-05-12 7:58 [PATCH] regulator: cros-ec: Fix error code in dev_err message Axel Lin
@ 2021-05-12 17:04 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-05-12 17:04 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, linux-kernel, Pi-Hsun Shih
On Wed, 12 May 2021 15:58:24 +0800, Axel Lin wrote:
> Show proper error code instead of 0.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: cros-ec: Fix error code in dev_err message
commit: 3d681804efcb6e5d8089a433402e19179347d7ae
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 7:58 [PATCH] regulator: cros-ec: Fix error code in dev_err message Axel Lin
2021-05-12 17:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).