* [PATCH] sched: fix a stale comment in pick_next_task()
@ 2021-05-19 6:37 Masahiro Yamada
2021-05-19 11:23 ` [tip: sched/core] sched: Fix " tip-bot2 for Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-05-19 6:37 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira
Cc: Masahiro Yamada, linux-kernel
fair_sched_class->next no longer exists since commit a87e749e8fa1
("sched: Remove struct sched_class::next field").
Now the sched_class order is specified by the linker script.
Rewrite the comment in a more generic way.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5226cc26a095..fd3b7079b9f2 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4961,7 +4961,7 @@ pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
if (unlikely(p == RETRY_TASK))
goto restart;
- /* Assumes fair_sched_class->next == idle_sched_class */
+ /* Assume the next prioritized class is idle_sched_class */
if (!p) {
put_prev_task(rq, prev);
p = pick_next_task_idle(rq);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: sched/core] sched: Fix a stale comment in pick_next_task()
2021-05-19 6:37 [PATCH] sched: fix a stale comment in pick_next_task() Masahiro Yamada
@ 2021-05-19 11:23 ` tip-bot2 for Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Masahiro Yamada @ 2021-05-19 11:23 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Masahiro Yamada, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1699949d3314e5d1956fb082e4cd4798bf6149fc
Gitweb: https://git.kernel.org/tip/1699949d3314e5d1956fb082e4cd4798bf6149fc
Author: Masahiro Yamada <masahiroy@kernel.org>
AuthorDate: Wed, 19 May 2021 15:37:09 +09:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 19 May 2021 13:03:21 +02:00
sched: Fix a stale comment in pick_next_task()
fair_sched_class->next no longer exists since commit:
a87e749e8fa1 ("sched: Remove struct sched_class::next field").
Now the sched_class order is specified by the linker script.
Rewrite the comment in a more generic way.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210519063709.323162-1-masahiroy@kernel.org
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3ec420c..3d25272 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5318,7 +5318,7 @@ __pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
if (unlikely(p == RETRY_TASK))
goto restart;
- /* Assumes fair_sched_class->next == idle_sched_class */
+ /* Assume the next prioritized class is idle_sched_class */
if (!p) {
put_prev_task(rq, prev);
p = pick_next_task_idle(rq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-19 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 6:37 [PATCH] sched: fix a stale comment in pick_next_task() Masahiro Yamada
2021-05-19 11:23 ` [tip: sched/core] sched: Fix " tip-bot2 for Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).