* [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings
@ 2021-05-27 9:54 Zou Wei
2021-05-27 10:10 ` Vaittinen, Matti
2021-05-28 16:04 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-05-27 9:54 UTC (permalink / raw)
To: matti.vaittinen, lgirdwood, broonie; +Cc: linux-power, linux-kernel, Zou Wei
./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/regulator/bd71815-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
index a079efa..4dd21ac 100644
--- a/drivers/regulator/bd71815-regulator.c
+++ b/drivers/regulator/bd71815-regulator.c
@@ -641,7 +641,6 @@ MODULE_DEVICE_TABLE(platform, bd7181x_pmic_id);
static struct platform_driver bd7181x_regulator = {
.driver = {
.name = "bd7181x-pmic",
- .owner = THIS_MODULE,
},
.probe = bd7181x_probe,
.id_table = bd7181x_pmic_id,
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings
2021-05-27 9:54 [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings Zou Wei
@ 2021-05-27 10:10 ` Vaittinen, Matti
2021-05-28 16:04 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Vaittinen, Matti @ 2021-05-27 10:10 UTC (permalink / raw)
To: lgirdwood, broonie, zou_wei; +Cc: linux-power, linux-kernel
On Thu, 2021-05-27 at 17:54 +0800, Zou Wei wrote:
> ./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set
> .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Thanks!
Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> drivers/regulator/bd71815-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/bd71815-regulator.c
> b/drivers/regulator/bd71815-regulator.c
> index a079efa..4dd21ac 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -641,7 +641,6 @@ MODULE_DEVICE_TABLE(platform, bd7181x_pmic_id);
> static struct platform_driver bd7181x_regulator = {
> .driver = {
> .name = "bd7181x-pmic",
> - .owner = THIS_MODULE,
> },
> .probe = bd7181x_probe,
> .id_table = bd7181x_pmic_id,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings
2021-05-27 9:54 [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings Zou Wei
2021-05-27 10:10 ` Vaittinen, Matti
@ 2021-05-28 16:04 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-05-28 16:04 UTC (permalink / raw)
To: matti.vaittinen, lgirdwood, Zou Wei
Cc: Mark, Brown, broonie, linux-kernel, linux-power
From: Mark Brown,,, <broonie@kernel.org>
On Thu, 27 May 2021 17:54:04 +0800, Zou Wei wrote:
> ./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Applied, thanks!
[1/1] regulator: bd71815: fix platform_no_drv_owner.cocci warnings
commit: d149b855b955fe92ab16ddd59c1d540f82e6a40f
Best regards,
--
Mark Brown,,, <broonie@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-28 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 9:54 [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci warnings Zou Wei
2021-05-27 10:10 ` Vaittinen, Matti
2021-05-28 16:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).