* [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf()
@ 2021-06-04 10:20 Yang Li
2021-06-04 10:20 ` [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() Yang Li
2021-06-05 18:05 ` [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Serge Semin
0 siblings, 2 replies; 4+ messages in thread
From: Yang Li @ 2021-06-04 10:20 UTC (permalink / raw)
To: jdmason; +Cc: dave.jiang, allenbh, linux-ntb, linux-kernel, Yang Li
When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/ntb/test/ntb_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 89df135..c20b375 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer)
return -ENOMEM;
}
if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) {
+ ret = -ENOMEM;
dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n");
goto err_free_inbuf;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe()
2021-06-04 10:20 [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Yang Li
@ 2021-06-04 10:20 ` Yang Li
2021-06-04 15:18 ` Logan Gunthorpe
2021-06-05 18:05 ` [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Serge Semin
1 sibling, 1 reply; 4+ messages in thread
From: Yang Li @ 2021-06-04 10:20 UTC (permalink / raw)
To: jdmason; +Cc: dave.jiang, allenbh, linux-ntb, linux-kernel, Yang Li
When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error
code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/ntb/test/ntb_msi_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c
index 7095ecd..5f9e0be 100644
--- a/drivers/ntb/test/ntb_msi_test.c
+++ b/drivers/ntb/test/ntb_msi_test.c
@@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
if (ret)
goto remove_dbgfs;
- if (!nm->isr_ctx)
+ if (!nm->isr_ctx) {
+ return -ENOMEM;
goto remove_dbgfs;
+ }
ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe()
2021-06-04 10:20 ` [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() Yang Li
@ 2021-06-04 15:18 ` Logan Gunthorpe
0 siblings, 0 replies; 4+ messages in thread
From: Logan Gunthorpe @ 2021-06-04 15:18 UTC (permalink / raw)
To: Yang Li, jdmason; +Cc: dave.jiang, allenbh, linux-ntb, linux-kernel
On 2021-06-04 4:20 a.m., Yang Li wrote:
> When the value of nm->isr_ctx is false, the value of ret is 0.
> So, we set ret to -ENOMEM to indicate this error.
>
> Clean up smatch warning:
> drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error
> code 'ret'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/ntb/test/ntb_msi_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c
> index 7095ecd..5f9e0be 100644
> --- a/drivers/ntb/test/ntb_msi_test.c
> +++ b/drivers/ntb/test/ntb_msi_test.c
> @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
> if (ret)
> goto remove_dbgfs;
>
> - if (!nm->isr_ctx)
> + if (!nm->isr_ctx) {
> + return -ENOMEM;
> goto remove_dbgfs;
I think you made a typo here. You probably meant ret = -ENOMEM.
Thanks,
Logan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf()
2021-06-04 10:20 [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Yang Li
2021-06-04 10:20 ` [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() Yang Li
@ 2021-06-05 18:05 ` Serge Semin
1 sibling, 0 replies; 4+ messages in thread
From: Serge Semin @ 2021-06-05 18:05 UTC (permalink / raw)
To: Yang Li; +Cc: jdmason, dave.jiang, allenbh, linux-ntb, linux-kernel
Hello Yang.
On Fri, Jun 04, 2021 at 06:20:50PM +0800, Yang Li wrote:
> When the function IS_ALIGNED() returns false, the value of ret is 0.
> So, we set ret to -ENOMEM to indicate this error.
>
> Clean up smatch warning:
> drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
> code 'ret'.
Great catch! Thanks for posing the fix. Indeed ret would zero in case of
unaligned buffer allocation. Though such situation is very improbable.
A tiny nitpick below.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/ntb/test/ntb_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 89df135..c20b375 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer)
> return -ENOMEM;
> }
> if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) {
> + ret = -ENOMEM;
I'd set -EINVAL here. In this case we do have enough memory, but the
base address is unaligned in a way the NTB hw requires. After fixing
that feel free to add:
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n");
> goto err_free_inbuf;
> }
> --
> 1.8.3.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/1622802051-43464-1-git-send-email-yang.lee%40linux.alibaba.com.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-05 18:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 10:20 [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Yang Li
2021-06-04 10:20 ` [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() Yang Li
2021-06-04 15:18 ` Logan Gunthorpe
2021-06-05 18:05 ` [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Serge Semin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).