From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 15/16] net: farsync: remove redundant return
Date: Tue, 8 Jun 2021 16:12:41 +0800 [thread overview]
Message-ID: <1623139962-34847-16-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623139962-34847-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
Void function return statements are not generally useful.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/farsync.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 3aea3d3..10208f0 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -1156,7 +1156,6 @@ fst_recover_rx_error(struct fst_card_info *card, struct fst_port_info *port,
rxp = (rxp + 1) % NUM_RX_BUFFER;
}
port->rxpos = rxp;
- return;
}
/* Rx complete interrupt
--
2.8.1
next prev parent reply other threads:[~2021-06-08 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:12 [PATCH net-next 00/16] net: farsync: clean up some code style issues Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 01/16] net: farsync: remove redundant blank lines Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 02/16] net: farsync: add blank line after declarations Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 03/16] net: farsync: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 04/16] net: farsync: move out assignment in if condition Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 05/16] net: farsync: remove redundant initialization for statics Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 06/16] net: farsync: fix the comments style issue Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 07/16] net: farsync: remove trailing whitespaces Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 08/16] net: farsync: code indent use tabs where possible Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 09/16] net: farsync: fix the code style issue about macros Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 10/16] net: farsync: add some required spaces Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 11/16] net: farsync: remove redundant braces {} Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 12/16] net: farsync: remove redundant spaces Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 13/16] net: farsync: remove redundant parentheses Guangbin Huang
2021-06-08 8:12 ` [PATCH net-next 14/16] net: farsync: fix the alignment issue Guangbin Huang
2021-06-08 8:12 ` Guangbin Huang [this message]
2021-06-08 8:12 ` [PATCH net-next 16/16] net: farsync: replace comparison to NULL with "fst_card_array[i]" Guangbin Huang
2021-06-08 19:10 ` [PATCH net-next 00/16] net: farsync: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623139962-34847-16-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).