* [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource()
@ 2021-06-09 14:01 Yang Yingliang
2021-06-09 17:18 ` Grygorii Strashko
2021-06-10 20:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-06-09 14:01 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: davem, kuba, grygorii.strashko
Use devm_platform_get_and_ioremap_resource() to simplify
code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/ti/cpsw.c | 3 +--
drivers/net/ethernet/ti/cpsw_new.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c0cd7de88316..b1e80cc96f56 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1532,8 +1532,7 @@ static int cpsw_probe(struct platform_device *pdev)
}
cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000;
- ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ss_regs = devm_ioremap_resource(dev, ss_res);
+ ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res);
if (IS_ERR(ss_regs))
return PTR_ERR(ss_regs);
cpsw->regs = ss_regs;
diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 69b7a4e0220a..8d4f3c53385d 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -1883,8 +1883,7 @@ static int cpsw_probe(struct platform_device *pdev)
}
cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000;
- ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ss_regs = devm_ioremap_resource(dev, ss_res);
+ ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res);
if (IS_ERR(ss_regs)) {
ret = PTR_ERR(ss_regs);
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource()
2021-06-09 14:01 [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
@ 2021-06-09 17:18 ` Grygorii Strashko
2021-06-10 20:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2021-06-09 17:18 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, netdev; +Cc: davem, kuba
On 09/06/2021 17:01, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/ti/cpsw.c | 3 +--
> drivers/net/ethernet/ti/cpsw_new.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c0cd7de88316..b1e80cc96f56 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1532,8 +1532,7 @@ static int cpsw_probe(struct platform_device *pdev)
> }
> cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000;
>
> - ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ss_regs = devm_ioremap_resource(dev, ss_res);
> + ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res);
> if (IS_ERR(ss_regs))
> return PTR_ERR(ss_regs);
> cpsw->regs = ss_regs;
> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
> index 69b7a4e0220a..8d4f3c53385d 100644
> --- a/drivers/net/ethernet/ti/cpsw_new.c
> +++ b/drivers/net/ethernet/ti/cpsw_new.c
> @@ -1883,8 +1883,7 @@ static int cpsw_probe(struct platform_device *pdev)
> }
> cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000;
>
> - ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ss_regs = devm_ioremap_resource(dev, ss_res);
> + ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res);
> if (IS_ERR(ss_regs)) {
> ret = PTR_ERR(ss_regs);
> return ret;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource()
2021-06-09 14:01 [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2021-06-09 17:18 ` Grygorii Strashko
@ 2021-06-10 20:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-10 20:40 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, davem, kuba, grygorii.strashko
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 9 Jun 2021 22:01:52 +0800 you wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/ti/cpsw.c | 3 +--
> drivers/net/ethernet/ti/cpsw_new.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/netdev/net-next/c/aced6d37df79
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-10 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 14:01 [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2021-06-09 17:18 ` Grygorii Strashko
2021-06-10 20:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).