From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 2/8] net: hdlc_ppp: add blank line after declarations
Date: Wed, 16 Jun 2021 17:33:51 +0800 [thread overview]
Message-ID: <1623836037-26812-3-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623836037-26812-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
This patch fixes the checkpatch error about missing a blank line
after declarations.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/hdlc_ppp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index e25b2f0..32f01d7 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -41,6 +41,7 @@ static const char *const code_names[CP_CODES] = {
"0", "ConfReq", "ConfAck", "ConfNak", "ConfRej", "TermReq",
"TermAck", "CodeRej", "ProtoRej", "EchoReq", "EchoReply", "Discard"
};
+
static char debug_buffer[64 + 3 * DEBUG_CP];
#endif
@@ -90,6 +91,7 @@ static const char *const state_names[STATES] = {
"Closed", "Stopped", "Stopping", "ReqSent", "AckRecv", "AckSent",
"Opened"
};
+
static const char *const event_names[EVENTS] = {
"Start", "Stop", "TO+", "TO-", "RCR+", "RCR-", "RCA", "RCN",
"RTR", "RTA", "RUC", "RXJ+", "RXJ-"
@@ -194,6 +196,7 @@ static int ppp_hard_header(struct sk_buff *skb, struct net_device *dev,
static void ppp_tx_flush(void)
{
struct sk_buff *skb;
+
while ((skb = skb_dequeue(&tx_queue)) != NULL)
dev_queue_xmit(skb);
}
@@ -616,6 +619,7 @@ static void ppp_start(struct net_device *dev)
for (i = 0; i < IDX_COUNT; i++) {
struct proto *proto = &ppp->protos[i];
+
proto->dev = dev;
timer_setup(&proto->timer, ppp_timer, 0);
proto->state = CLOSED;
--
2.8.1
next prev parent reply other threads:[~2021-06-16 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:33 [PATCH net-next 0/8] net: hdlc_ppp: clean up some code style issues Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 1/8] net: hdlc_ppp: remove redundant blank lines Guangbin Huang
2021-06-16 9:33 ` Guangbin Huang [this message]
2021-06-16 9:33 ` [PATCH net-next 3/8] net: hdlc_ppp: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 4/8] net: hdlc_ppp: move out assignment in if condition Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue Guangbin Huang
2021-06-16 16:20 ` Andrew Lunn
2021-06-17 1:00 ` lipeng (Y)
2021-06-16 9:33 ` [PATCH net-next 6/8] net: hdlc_ppp: remove unnecessary out of memory message Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces Guangbin Huang
2021-06-16 16:23 ` Andrew Lunn
2021-06-17 1:05 ` lipeng (Y)
2021-06-16 9:33 ` [PATCH net-next 8/8] net: hdlc_ppp: add required space Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623836037-26812-3-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).