From: "lipeng (Y)" <lipeng321@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>, Guangbin Huang <huangguangbin2@huawei.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue
Date: Thu, 17 Jun 2021 09:00:56 +0800 [thread overview]
Message-ID: <fed0521c-8ae0-7e71-fb87-94c4fd08e21d@huawei.com> (raw)
In-Reply-To: <YMoktwkvCP8yGyhk@lunn.ch>
在 2021/6/17 0:20, Andrew Lunn 写道:
>> static int cp_table[EVENTS][STATES] = {
>> /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
>> - 0 1 2 3 4 5 6 */
>> + * 0 1 2 3 4 5 6
>> + */
>> {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */
>> { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */
>> { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */
> This probably reduces the readability of the code. So i would not make
> this change.
>
> Please remember these are only guidelines. Please don't blindly make
> changes, or change it because some bot says so. Check that it actually
> makes sense and the code is better afterwards.
>
> Andrew
> .
Agree with you they are only guidelines.
The code should follow the rules mostly, or it will be diferent style
from different developer.
If that's the exception, i will drop this patch.
Thanks
Peng Li
next prev parent reply other threads:[~2021-06-17 1:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:33 [PATCH net-next 0/8] net: hdlc_ppp: clean up some code style issues Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 1/8] net: hdlc_ppp: remove redundant blank lines Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 2/8] net: hdlc_ppp: add blank line after declarations Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 3/8] net: hdlc_ppp: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 4/8] net: hdlc_ppp: move out assignment in if condition Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue Guangbin Huang
2021-06-16 16:20 ` Andrew Lunn
2021-06-17 1:00 ` lipeng (Y) [this message]
2021-06-16 9:33 ` [PATCH net-next 6/8] net: hdlc_ppp: remove unnecessary out of memory message Guangbin Huang
2021-06-16 9:33 ` [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces Guangbin Huang
2021-06-16 16:23 ` Andrew Lunn
2021-06-17 1:05 ` lipeng (Y)
2021-06-16 9:33 ` [PATCH net-next 8/8] net: hdlc_ppp: add required space Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed0521c-8ae0-7e71-fb87-94c4fd08e21d@huawei.com \
--to=lipeng321@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).