linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static
@ 2021-06-12  9:27 Zou Wei
  2021-06-18 16:03 ` [tip: timers/core] " tip-bot2 for Zou Wei
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-06-12  9:27 UTC (permalink / raw)
  To: patrice.chotard, daniel.lezcano, tglx
  Cc: linux-arm-kernel, linux-kernel, Zou Wei

The sparse tool complains as follows:

drivers/clocksource/arm_global_timer.c:54:23: warning:
 symbol 'gt_clk_rate_change_nb' was not declared. Should it be static?

This symbol is not used outside of arm_global_timer.c, so marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/clocksource/arm_global_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 60a8047..68b1d14 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -51,7 +51,7 @@
  * the units for all operations.
  */
 static void __iomem *gt_base;
-struct notifier_block gt_clk_rate_change_nb;
+static struct notifier_block gt_clk_rate_change_nb;
 static u32 gt_psv_new, gt_psv_bck, gt_target_rate;
 static int gt_ppi;
 static struct clock_event_device __percpu *gt_evt;
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip: timers/core] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static
  2021-06-12  9:27 [PATCH -next] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static Zou Wei
@ 2021-06-18 16:03 ` tip-bot2 for Zou Wei
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Zou Wei @ 2021-06-18 16:03 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Hulk Robot, Zou Wei, Daniel Lezcano, x86, linux-kernel

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     be534f8ee137b95046d7c53c8200ffdcf05781a7
Gitweb:        https://git.kernel.org/tip/be534f8ee137b95046d7c53c8200ffdcf05781a7
Author:        Zou Wei <zou_wei@huawei.com>
AuthorDate:    Sat, 12 Jun 2021 17:27:26 +08:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Wed, 16 Jun 2021 17:33:04 +02:00

clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static

The sparse tool complains as follows:

drivers/clocksource/arm_global_timer.c:54:23: warning:
 symbol 'gt_clk_rate_change_nb' was not declared. Should it be static?

This symbol is not used outside of arm_global_timer.c, so mark it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/1623490046-37972-1-git-send-email-zou_wei@huawei.com
---
 drivers/clocksource/arm_global_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 60a8047..68b1d14 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -51,7 +51,7 @@
  * the units for all operations.
  */
 static void __iomem *gt_base;
-struct notifier_block gt_clk_rate_change_nb;
+static struct notifier_block gt_clk_rate_change_nb;
 static u32 gt_psv_new, gt_psv_bck, gt_target_rate;
 static int gt_ppi;
 static struct clock_event_device __percpu *gt_evt;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-18 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12  9:27 [PATCH -next] clocksource/drivers/arm_global_timer: Make symbol 'gt_clk_rate_change_nb' static Zou Wei
2021-06-18 16:03 ` [tip: timers/core] " tip-bot2 for Zou Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).