* [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc
@ 2021-06-19 12:14 Alex Bee
2021-06-19 21:58 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bee @ 2021-06-19 12:14 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Markus Reichl, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, Alex Bee
This might be a limitation of either the current panfrost driver
devfreq implementation or how the gpu is implemented in RK3399 SoC.
The gpu regulator must never get disabled or the registers get
(randomly?) inaccessable by the driver. (see all other RK3399 boards)
Fixes: ec7d731d81e7 ("arm64: dts: rockchip: Add node for gpu on rk3399-roc-pc")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index da3021dc0ff3..8b27ee4be755 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -494,6 +494,8 @@ vdd_gpu: regulator@41 {
regulator-min-microvolt = <712500>;
regulator-max-microvolt = <1500000>;
regulator-ramp-delay = <1000>;
+ regulator-always-on;
+ regulator-boot-on;
vin-supply = <&vcc3v3_sys>;
regulator-state-mem {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc
2021-06-19 12:14 [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc Alex Bee
@ 2021-06-19 21:58 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-06-19 21:58 UTC (permalink / raw)
To: Alex Bee
Cc: Heiko Stuebner, devicetree, linux-rockchip, Rob Herring,
linux-arm-kernel, linux-kernel, Markus Reichl
On Sat, 19 Jun 2021 14:14:46 +0200, Alex Bee wrote:
> This might be a limitation of either the current panfrost driver
> devfreq implementation or how the gpu is implemented in RK3399 SoC.
> The gpu regulator must never get disabled or the registers get
> (randomly?) inaccessable by the driver. (see all other RK3399 boards)
Applied, thanks!
[1/1] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc
commit: 06b2818678d9b35102c9816ffaf6893caf306ed0
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-19 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 12:14 [PATCH] arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc Alex Bee
2021-06-19 21:58 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).